Attachment 98151 Details for Bug 22844 – Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

[patch] Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Bug-22844-follow-up-Make-the-attribute-mandatory-w.patch (text/plain), 2.76 KB, created by David Nind on 2020-01-30 10:08:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-01-30 10:08:16 UTC

Size: 2.76 KB

patch

obsolete

>From 5ca34d0fc2af32c87637cec7ea172eb85d484966 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 5 Dec 2019 11:27:16 +0100
>Subject: [PATCH] Bug 22844: (follow-up) Make the attribute mandatory when
> editing a patron
>
>Previous patch forgot the most important, adding the required attribute
>to the select/textarea
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 5ead1db703..87749f5023 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1131,7 +1131,11 @@
>                         <label for="[% patron_attribute.form_id | html %]">[% patron_attribute.description | html %]: </label>
>                     [% END %]
>                         [% IF ( patron_attribute.use_dropdown ) %]
>+                            [% IF patron_attribute.mandatory %]
>+                            <select id="[% patron_attribute.form_id | html %]" name="[% patron_attribute.form_id | html %]" required="required">
>+                            [% ELSE %]
>                             <select id="[% patron_attribute.form_id | html %]" name="[% patron_attribute.form_id | html %]">
>+                            [% END %]
>                                 <option value=""></option>
>                                 [% FOREACH auth_val_loo IN patron_attribute.auth_val_loop %]
>                                     [% IF auth_val_loo.authorised_value == patron_attribute.value %]
>@@ -1146,7 +1150,11 @@
>                                 [% END %]
>                             </select>
>                         [% ELSE %]
>+                            [% IF patron_attribute.mandatory %]
>+                            <textarea rows="2" cols="30" id="[% patron_attribute.form_id | html %]" name="[% patron_attribute.form_id | html %]" required="required">[% patron_attribute.value | html %]</textarea>
>+                            [% ELSE %]
>                             <textarea rows="2" cols="30" id="[% patron_attribute.form_id | html %]" name="[% patron_attribute.form_id | html %]">[% patron_attribute.value | html %]</textarea>
>+                            [% END %]
>                         [% END %]
>                         <input type="hidden" id="[% patron_attribute.form_id | html %]_code" name="[% patron_attribute.form_id | html %]_code" value="[% patron_attribute.code | html %]" />
>                         <a href="#" onclick="clear_entry(this); return false;"><i class="fa fa-fw fa-trash"></i> Clear</a>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22844: 89322 | 89323 | 89389 | 89403 | 89530 | 89531 | 89749 | 89903 | 89904 | 89905 | 90407 | 96007 | 98145 | 98146 | 98147 | 98148 | 98149 | 98150 | 98151 | 98297 | 98298 | 100440 | 100441 | 100442 | 100443 | 100444 | 100445 | 100446 | 100447 | 101198 | 101199 | 101200 | 101201 | 101202 | 101203 | 101204 | 101205 | 101302 | 101480 | 101481 | 101482 | 101483 | 101484 | 101485 | 101486 | 101487 | 101488 | 101617 | 101618 | 101619 | 101620 | 101621 | 101622 | 101623 | 101624 | 103842 | 103843 | 103844 | 103845 | 103846 | 103847 | 103848 | 103849 | 103850 | 103904 | 103960 | 103961 | 103962 | 103963 | 103964 | 103965 | 103966 | 103967 | 103968 | 103969 | 106545 | 106546 | 106547 | 106548 | 106549 | 106550 | 106551 | 106552 | 106553 | 106554 | 107126