Attachment 98161 Details for Bug 24532 – Bug 24532: Fix original DB update for bug 23049

[patch] Bug 24532: Fix original DB update for bug 23049

Bug-24532-Fix-original-DB-update-for-bug-23049.patch (text/plain), 1.21 KB, created by Martin Renvoize (ashimema) on 2020-01-30 14:40:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-01-30 14:40:22 UTC

Size: 1.21 KB

patch

obsolete

>From 2fa95e61e3f031a5d653c2e744266bc8d32d59a7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 30 Jan 2020 13:19:37 +0000
>Subject: [PATCH] Bug 24532: Fix original DB update for bug 23049
>
>Pathalogical cases of Payments and Writeoffs being converted to debits
>are identified during the DB update for bug 23049, but we are not
>correctly limiting to those types accountlines when subsequently
>populating the debit_type field.
>---
> installer/data/mysql/updatedatabase.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index e4fa236c0a..18540e127d 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -19919,7 +19919,7 @@ if ( CheckVersion($DBversion) ) {
>     # Populating debit_type_code
>     $dbh->do(
>         qq{
>-        UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types)
>+        UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) AND amount >= 0
>         }
>     );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24532: 98161 | 98162 | 98811 | 98812