Attachment 98204 Details for Bug 24213 – Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted

[patch] Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted

Bug-24213-Fix-KohaObject-getfromstorage-if-the-obj.patch (text/plain), 1.20 KB, created by Marcel de Rooy on 2020-01-31 06:46:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-01-31 06:46:26 UTC

Size: 1.20 KB

patch

obsolete

>From aa164581828f2bfadd63335ec0fb54ab1824102b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 11 Dec 2019 09:39:30 +0100
>Subject: [PATCH] Bug 24213: Fix Koha::Object->get_from_storage if the object
> has been deleted
>Content-Type: text/plain; charset=utf-8
>
>Without this patch it fails with something like:
>  DBIC result _type  isn't of the _type Subscription at t/db_dependent/Biblio.t line 627.
>
>Test plan:
>- Apply the first patch (Add tests)
>- Confirm that they fail
>- Apply this patch
>- Confirm that the tests pass
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Object.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index 5f28c35808..50a0b8e5cd 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -280,6 +280,7 @@ sub unblessed {
> sub get_from_storage {
>     my ( $self, $attrs ) = @_;
>     my $stored_object = $self->_result->get_from_storage($attrs);
>+    return unless $stored_object;
>     my $object_class  = Koha::Object::_get_object_class( $self->_result->result_class );
>     return $object_class->_new_from_dbic($stored_object);
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24213: 96179 | 96180 | 98175 | 98176 | 98203 | 98204