Bugzilla – Attachment 98220 Details for
Bug 24467
*_count methods should be avoided
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24467: (QA follow-up) Clarify tests wording for ->count methods
Bug-24467-QA-follow-up-Clarify-tests-wording-for--.patch (text/plain), 1.53 KB, created by
Josef Moravec
on 2020-01-31 09:51:38 UTC
(
hide
)
Description:
Bug 24467: (QA follow-up) Clarify tests wording for ->count methods
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2020-01-31 09:51:38 UTC
Size:
1.53 KB
patch
obsolete
>From 969909d6ed7909e720b3a03ade081ac2a13ef79a Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 31 Jan 2020 09:47:54 +0000 >Subject: [PATCH] Bug 24467: (QA follow-up) Clarify tests wording for ->count > methods > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Koha/Biblio.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t >index 75921933c6..2abacff51a 100644 >--- a/t/db_dependent/Koha/Biblio.t >+++ b/t/db_dependent/Koha/Biblio.t >@@ -507,7 +507,7 @@ subtest 'orders() and active_orders() tests' => sub { > my $active_orders = $biblio->active_orders; > > is( ref($orders), 'Koha::Acquisition::Orders', 'Result type is correct' ); >- is( $biblio->orders->count, $biblio->active_orders->count, '->orders_count returns the count for the resultset' ); >+ is( $biblio->orders->count, $biblio->active_orders->count, '->orders->count returns the count for the resultset' ); > > # Add a couple orders > foreach (1..2) { >@@ -537,7 +537,7 @@ subtest 'orders() and active_orders() tests' => sub { > > is( ref($orders), 'Koha::Acquisition::Orders', 'Result type is correct' ); > is( ref($active_orders), 'Koha::Acquisition::Orders', 'Result type is correct' ); >- is( $orders->count, $active_orders->count + 2, '->active_orders_count returns the rigt count' ); >+ is( $orders->count, $active_orders->count + 2, '->active_orders->count returns the rigt count' ); > > $schema->storage->txn_rollback; > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24467
:
97746
|
98198
|
98202
|
98218
|
98219
| 98220