Bugzilla – Attachment 98291 Details for
Bug 24566
UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled
Bug-24566-UpdateItemLocationOnCheckin-triggers-SIP.patch (text/plain), 1.40 KB, created by
Kyle M Hall (khall)
on 2020-02-03 13:00:54 UTC
(
hide
)
Description:
Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-02-03 13:00:54 UTC
Size:
1.40 KB
patch
obsolete
>From e9286fef60e1013187078202561bcf596f39d785 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 3 Feb 2020 07:56:37 -0500 >Subject: [PATCH] Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert > flag, even with checked_in_ok enabled > >If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. > >Test Plan: >1) Enable UpdateItemLocationOnCheckin and set it up to trigger at >checkin for an item >2) Return that item via SIP2 >3) Note the alert flag is set >4) Apply this patch >5) Repeat steps 1 and 2 >6) The alert flag should not be set > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Kevin Cook <ILS@cedarparktexas.gov> >--- > C4/SIP/ILS/Transaction/Checkin.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index f0e8bbdf49..f1ed6532b7 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -72,6 +72,7 @@ sub do_checkin { > my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, dt_from_string($return_date)); > > if ( $checked_in_ok ) { >+ delete $messages->{ItemLocationUpdated}; > delete $messages->{NotIssued}; > delete $messages->{LocalUse}; > $return = 1 unless keys %$messages; >-- >2.21.1 (Apple Git-122.3)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24566
:
98290
|
98291
|
101003