Bugzilla – Attachment 98316 Details for
Bug 18936
Move issuingrules into circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18936: Replace an other insert into issuingrules
Bug-18936-Replace-an-other-insert-into-issuingrule.patch (text/plain), 2.50 KB, created by
Jonathan Druart
on 2020-02-03 16:07:16 UTC
(
hide
)
Description:
Bug 18936: Replace an other insert into issuingrules
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-03 16:07:16 UTC
Size:
2.50 KB
patch
obsolete
>From 43d4e50c8751e63a0c32460927d7b2ba0ef6000e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Feb 2019 19:06:39 -0300 >Subject: [PATCH] Bug 18936: Replace an other insert into issuingrules >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > t/db_dependent/Circulation.t | 28 +++++++++++++++++----------- > t/db_dependent/Circulation/GetHardDueDate.t | 2 +- > 2 files changed, 18 insertions(+), 12 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 7df409c2ce..eec4d0c064 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2974,17 +2974,23 @@ subtest 'ItemsDeniedRenewal preference' => sub { > C4::Context->set_preference('ItemsDeniedRenewal',''); > > my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'}); >- $dbh->do( >- q{ >- INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod, >- norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) >- }, >- {}, >- '*', $idr_lib->branchcode, '*', 25, >- 14, 'days', >- 10, 7, >- undef, 0, >- .10, 1 >+ Koha::CirculationRules->set_rules( >+ { >+ categorycode => '*', >+ itemtype => '*', >+ branchcode => $idr_lib->branchcode, >+ rules => { >+ reservesallowed => 25, >+ issuelength => 14, >+ lengthunit => 'days', >+ renewalsallowed => 10, >+ renewalperiod => 7, >+ norenewalbefore => undef, >+ auto_renew => 0, >+ fine => .10, >+ chargeperiod => 1, >+ } >+ } > ); > > my $deny_book = $builder->build_object({ class => 'Koha::Items', value => { >diff --git a/t/db_dependent/Circulation/GetHardDueDate.t b/t/db_dependent/Circulation/GetHardDueDate.t >index c61587f38e..47958d5e79 100644 >--- a/t/db_dependent/Circulation/GetHardDueDate.t >+++ b/t/db_dependent/Circulation/GetHardDueDate.t >@@ -10,7 +10,7 @@ use Koha::Library; > > use t::lib::TestBuilder; > >-use Test::More tests => 10; >+use Test::More tests => 9; > > BEGIN { > use_ok('C4::Circulation'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18936
:
65247
|
65248
|
65249
|
67629
|
67758
|
68236
|
71034
|
71035
|
71036
|
71037
|
71038
|
71039
|
71040
|
71041
|
72230
|
72231
|
72232
|
72233
|
72234
|
72235
|
72236
|
72237
|
72238
|
91953
|
91954
|
91955
|
91956
|
91957
|
91958
|
91959
|
91960
|
91961
|
91962
|
91963
|
91964
|
91965
|
91966
|
91967
|
91968
|
91969
|
91970
|
91971
|
91972
|
91973
|
91974
|
91975
|
94179
|
94180
|
94181
|
94182
|
94183
|
94184
|
94185
|
94186
|
94187
|
94188
|
94189
|
94190
|
94191
|
94192
|
94193
|
94194
|
94195
|
94196
|
94197
|
94198
|
94199
|
94200
|
98299
|
98300
|
98301
|
98302
|
98303
|
98304
|
98305
|
98306
|
98307
|
98308
|
98309
|
98310
|
98311
|
98312
|
98313
|
98314
|
98315
| 98316 |
98317
|
98318
|
98319
|
98320
|
98321
|
98322
|
98323
|
98324
|
98325
|
98326
|
98327
|
98328
|
98329
|
98330
|
98331
|
98332
|
98333
|
98334
|
98335
|
98336
|
98337
|
98338
|
98339
|
98340
|
98341
|
98342
|
98343
|
98344
|
98345
|
98346
|
98347
|
98407
|
98408