Bugzilla – Attachment 98325 Details for
Bug 18936
Move issuingrules into circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18936: (follow-up) Add missing circulation rule to fix tests
Bug-18936-follow-up-Add-missing-circulation-rule-t.patch (text/plain), 1.61 KB, created by
Jonathan Druart
on 2020-02-03 16:08:04 UTC
(
hide
)
Description:
Bug 18936: (follow-up) Add missing circulation rule to fix tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-03 16:08:04 UTC
Size:
1.61 KB
patch
obsolete
>From bddf9066bbcac50a2656d281da73f93d8e2af0ca Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 22 Jan 2020 19:03:03 +0200 >Subject: [PATCH] Bug 18936: (follow-up) Add missing circulation rule to fix > tests >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The tests passed before by a chance because the default kohadevbox >installation script added a issuing rule that had lengthunit = >days. If you use a Koha version before the commits introduced by Bug >18936 you can reproduce the Fees.t tests failing by deleting all the >issuing rules from database with > >> delete issuingrules; > >and then running > >$ prove t/db_dependent/Koha/Charges/Fees.t > >Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > t/db_dependent/Koha/Charges/Fees.t | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/t/db_dependent/Koha/Charges/Fees.t b/t/db_dependent/Koha/Charges/Fees.t >index 431e292a54..e015927074 100644 >--- a/t/db_dependent/Koha/Charges/Fees.t >+++ b/t/db_dependent/Koha/Charges/Fees.t >@@ -320,6 +320,16 @@ subtest 'accumulate_rentalcharge tests' => sub { > ); > > # Daily tests >+ Koha::CirculationRules->set_rules({ >+ categorycode => $patron->categorycode, >+ itemtype => $itemtype->id, >+ branchcode => $library->id, >+ rules => { >+ lengthunit => 'days', >+ } >+ } >+ ); >+ > $itemtype->rentalcharge_daily(1.00); > $itemtype->store(); > is( $itemtype->rentalcharge_daily, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18936
:
65247
|
65248
|
65249
|
67629
|
67758
|
68236
|
71034
|
71035
|
71036
|
71037
|
71038
|
71039
|
71040
|
71041
|
72230
|
72231
|
72232
|
72233
|
72234
|
72235
|
72236
|
72237
|
72238
|
91953
|
91954
|
91955
|
91956
|
91957
|
91958
|
91959
|
91960
|
91961
|
91962
|
91963
|
91964
|
91965
|
91966
|
91967
|
91968
|
91969
|
91970
|
91971
|
91972
|
91973
|
91974
|
91975
|
94179
|
94180
|
94181
|
94182
|
94183
|
94184
|
94185
|
94186
|
94187
|
94188
|
94189
|
94190
|
94191
|
94192
|
94193
|
94194
|
94195
|
94196
|
94197
|
94198
|
94199
|
94200
|
98299
|
98300
|
98301
|
98302
|
98303
|
98304
|
98305
|
98306
|
98307
|
98308
|
98309
|
98310
|
98311
|
98312
|
98313
|
98314
|
98315
|
98316
|
98317
|
98318
|
98319
|
98320
|
98321
|
98322
|
98323
|
98324
| 98325 |
98326
|
98327
|
98328
|
98329
|
98330
|
98331
|
98332
|
98333
|
98334
|
98335
|
98336
|
98337
|
98338
|
98339
|
98340
|
98341
|
98342
|
98343
|
98344
|
98345
|
98346
|
98347
|
98407
|
98408