Bugzilla – Attachment 98327 Details for
Bug 18936
Move issuingrules into circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18936: Insert default rules during the onboarding tool
Bug-18936-Insert-default-rules-during-the-onboardi.patch (text/plain), 3.86 KB, created by
Jonathan Druart
on 2020-02-03 16:08:14 UTC
(
hide
)
Description:
Bug 18936: Insert default rules during the onboarding tool
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-03 16:08:14 UTC
Size:
3.86 KB
patch
obsolete
>From 0d8dfd3bad9206ee56725a19b0dd7ab626e1e70f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jan 2020 16:01:13 +0100 >Subject: [PATCH] Bug 18936: Insert default rules during the onboarding tool >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Those default values have been picked from bug 15522 >(Koha::CirculationRules) > >Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > installer/onboarding.pl | 60 ++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 54 insertions(+), 6 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index 8951530a26..990dc9cc50 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -251,17 +251,65 @@ if ( $step == 5 ) { > categorycode => $categorycode, > itemtype => $itemtype, > rules => { >- renewalsallowed => $renewalsallowed, >- renewalperiod => $renewalperiod, >- issuelength => $issuelength, >- lengthunit => $lengthunit, >- onshelfholds => $onshelfholds, >+ renewalsallowed => $renewalsallowed, >+ renewalperiod => $renewalperiod, >+ issuelength => $issuelength, >+ lengthunit => $lengthunit, >+ onshelfholds => $onshelfholds, >+ article_requests => "no", >+ auto_renew => 0, >+ cap_fine_to_replacement_price => 0, >+ chargeperiod => 0, >+ chargeperiod_charge_at => 0, >+ fine => 0, >+ finedays => 0, >+ firstremind => 0, >+ hardduedate => "", >+ hardduedatecompare => -1, >+ holds_per_day => undef, >+ holds_per_record => 1, >+ maxissueqty => "", >+ maxonsiteissueqty => "", >+ maxsuspensiondays => "", >+ no_auto_renewal_after => "", >+ no_auto_renewal_after_hard_limit => "", >+ norenewalbefore => "", >+ opacitemholds => "N", >+ overduefinescap => "", >+ rentaldiscount => 0, >+ reservesallowed => 0, >+ suspension_chargeperiod => undef, >+ } >+ }; >+ >+ my $params_2 = { >+ branchcode => $branchcode, >+ categorycode => $categorycode, >+ rules => { >+ patron_maxissueqty => "", >+ patron_maxonsiteissueqty => "", >+ max_holds => "", >+ } >+ }; >+ >+ my $params_3 = { >+ branchcode => $branchcode, >+ itemtype => $itemtype, >+ rules => { >+ holdallowed => "", >+ hold_fulfillment_policy => "", >+ returnbranch => "", > } > }; > >- eval { Koha::CirculationRules->set_rules( $params ) }; >+ eval { >+ Koha::CirculationRules->set_rules($params); >+ Koha::CirculationRules->set_rules($params_2); >+ Koha::CirculationRules->set_rules($params_3); >+ }; > > if ($@) { >+ warn $@; > push @messages, { code => 'error_on_insert_circ_rule' }; > } else { > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18936
:
65247
|
65248
|
65249
|
67629
|
67758
|
68236
|
71034
|
71035
|
71036
|
71037
|
71038
|
71039
|
71040
|
71041
|
72230
|
72231
|
72232
|
72233
|
72234
|
72235
|
72236
|
72237
|
72238
|
91953
|
91954
|
91955
|
91956
|
91957
|
91958
|
91959
|
91960
|
91961
|
91962
|
91963
|
91964
|
91965
|
91966
|
91967
|
91968
|
91969
|
91970
|
91971
|
91972
|
91973
|
91974
|
91975
|
94179
|
94180
|
94181
|
94182
|
94183
|
94184
|
94185
|
94186
|
94187
|
94188
|
94189
|
94190
|
94191
|
94192
|
94193
|
94194
|
94195
|
94196
|
94197
|
94198
|
94199
|
94200
|
98299
|
98300
|
98301
|
98302
|
98303
|
98304
|
98305
|
98306
|
98307
|
98308
|
98309
|
98310
|
98311
|
98312
|
98313
|
98314
|
98315
|
98316
|
98317
|
98318
|
98319
|
98320
|
98321
|
98322
|
98323
|
98324
|
98325
|
98326
| 98327 |
98328
|
98329
|
98330
|
98331
|
98332
|
98333
|
98334
|
98335
|
98336
|
98337
|
98338
|
98339
|
98340
|
98341
|
98342
|
98343
|
98344
|
98345
|
98346
|
98347
|
98407
|
98408