Bugzilla – Attachment 98330 Details for
Bug 18936
Move issuingrules into circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18936: (follow-up 2) Add foreign key and scope enhancement to circ rules
Bug-18936-follow-up-2-Add-foreign-key-and-scope-en.patch (text/plain), 1.28 KB, created by
Jonathan Druart
on 2020-02-03 16:08:31 UTC
(
hide
)
Description:
Bug 18936: (follow-up 2) Add foreign key and scope enhancement to circ rules
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-03 16:08:31 UTC
Size:
1.28 KB
patch
obsolete
>From 7c9bef2787bcf69d8866553d69c594f04550f998 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 24 Jan 2020 14:54:45 +0100 >Subject: [PATCH] Bug 18936: (follow-up 2) Add foreign key and scope > enhancement to circ rules >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The previous patch modifies: >- categorycode => undef, >- itemtype => undef, >- branchcode => $branch, >+ branchcode => undef, > >But in that condition $branchcode is not '*' and so we should not set it >to undef > >Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > admin/smart-rules.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index 112efeb2ca..4d4ec5a6b3 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -555,7 +555,7 @@ elsif ( $op eq 'mod-refund-lost-item-fee-rule' ) { > } else { > Koha::CirculationRules->set_rules( > { >- branchcode => undef, >+ branchcode => $branch, > rules => { > refund => $refund > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18936
:
65247
|
65248
|
65249
|
67629
|
67758
|
68236
|
71034
|
71035
|
71036
|
71037
|
71038
|
71039
|
71040
|
71041
|
72230
|
72231
|
72232
|
72233
|
72234
|
72235
|
72236
|
72237
|
72238
|
91953
|
91954
|
91955
|
91956
|
91957
|
91958
|
91959
|
91960
|
91961
|
91962
|
91963
|
91964
|
91965
|
91966
|
91967
|
91968
|
91969
|
91970
|
91971
|
91972
|
91973
|
91974
|
91975
|
94179
|
94180
|
94181
|
94182
|
94183
|
94184
|
94185
|
94186
|
94187
|
94188
|
94189
|
94190
|
94191
|
94192
|
94193
|
94194
|
94195
|
94196
|
94197
|
94198
|
94199
|
94200
|
98299
|
98300
|
98301
|
98302
|
98303
|
98304
|
98305
|
98306
|
98307
|
98308
|
98309
|
98310
|
98311
|
98312
|
98313
|
98314
|
98315
|
98316
|
98317
|
98318
|
98319
|
98320
|
98321
|
98322
|
98323
|
98324
|
98325
|
98326
|
98327
|
98328
|
98329
| 98330 |
98331
|
98332
|
98333
|
98334
|
98335
|
98336
|
98337
|
98338
|
98339
|
98340
|
98341
|
98342
|
98343
|
98344
|
98345
|
98346
|
98347
|
98407
|
98408