Bugzilla – Attachment 98336 Details for
Bug 18936
Move issuingrules into circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18936: (follow-up) Make possible to have unlimited value for holds_per_day
Bug-18936-follow-up-Make-possible-to-have-unlimite.patch (text/plain), 1.88 KB, created by
Jonathan Druart
on 2020-02-03 16:09:03 UTC
(
hide
)
Description:
Bug 18936: (follow-up) Make possible to have unlimited value for holds_per_day
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-03 16:09:03 UTC
Size:
1.88 KB
patch
obsolete
>From d0e9cc812927cc65653145f27bc6351fcb3b869b Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Tue, 28 Jan 2020 15:05:15 +0000 >Subject: [PATCH] Bug 18936: (follow-up) Make possible to have unlimited value > for holds_per_day >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Without this it is not possible to make for a specific patron category >or itemtype a more specific unlimited holds_per_day rule if you have a >catch all rule (categorycode = *, itemtype = *) with limited >holds_per_day value. > >Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > C4/Reserves.pm | 2 +- > admin/smart-rules.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 86ff1faebb..f84922782e 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -404,7 +404,7 @@ sub CanItemBeReserved { > > if ( defined $holds_per_day && > ( ( $holds_per_day > 0 && $today_holds->count() >= $holds_per_day ) >- or ( $holds_per_day == 0 ) ) >+ or ( $holds_per_day == 0 && $holds_per_day ne '') ) > ) { > return { status => 'tooManyReservesToday', limit => $holds_per_day }; > } >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index ceb4a9be5b..75ed5164ca 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -277,7 +277,7 @@ elsif ($op eq 'add') { > my $holds_per_record = $input->param('holds_per_record'); > my $holds_per_day = $input->param('holds_per_day'); > $holds_per_day =~ s/\s//g; >- $holds_per_day = undef if $holds_per_day !~ /^\d+/; >+ $holds_per_day = '' if $holds_per_day !~ /^\d+/; > my $onshelfholds = $input->param('onshelfholds') || 0; > $maxissueqty =~ s/\s//g; > $maxissueqty = '' if $maxissueqty !~ /^\d+/; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18936
:
65247
|
65248
|
65249
|
67629
|
67758
|
68236
|
71034
|
71035
|
71036
|
71037
|
71038
|
71039
|
71040
|
71041
|
72230
|
72231
|
72232
|
72233
|
72234
|
72235
|
72236
|
72237
|
72238
|
91953
|
91954
|
91955
|
91956
|
91957
|
91958
|
91959
|
91960
|
91961
|
91962
|
91963
|
91964
|
91965
|
91966
|
91967
|
91968
|
91969
|
91970
|
91971
|
91972
|
91973
|
91974
|
91975
|
94179
|
94180
|
94181
|
94182
|
94183
|
94184
|
94185
|
94186
|
94187
|
94188
|
94189
|
94190
|
94191
|
94192
|
94193
|
94194
|
94195
|
94196
|
94197
|
94198
|
94199
|
94200
|
98299
|
98300
|
98301
|
98302
|
98303
|
98304
|
98305
|
98306
|
98307
|
98308
|
98309
|
98310
|
98311
|
98312
|
98313
|
98314
|
98315
|
98316
|
98317
|
98318
|
98319
|
98320
|
98321
|
98322
|
98323
|
98324
|
98325
|
98326
|
98327
|
98328
|
98329
|
98330
|
98331
|
98332
|
98333
|
98334
|
98335
| 98336 |
98337
|
98338
|
98339
|
98340
|
98341
|
98342
|
98343
|
98344
|
98345
|
98346
|
98347
|
98407
|
98408