Bugzilla – Attachment 98352 Details for
Bug 23260
Anonymize (remove) patron data from items_last_borrower
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23260: Proposed preference driven filtering
Bug-23260-Proposed-preference-driven-filtering.patch (text/plain), 2.71 KB, created by
Martin Renvoize (ashimema)
on 2020-02-03 17:05:02 UTC
(
hide
)
Description:
Bug 23260: Proposed preference driven filtering
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-02-03 17:05:02 UTC
Size:
2.71 KB
patch
obsolete
>From 4de2a58f54983ab3f3b7f99aaa36df18580018c1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 3 Feb 2020 17:04:19 +0000 >Subject: [PATCH] Bug 23260: Proposed preference driven filtering > >--- > Koha/Patrons.pm | 37 +++++++++++++++++++++++++------------ > 1 file changed, 25 insertions(+), 12 deletions(-) > >diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm >index 141209f87c..799df58fbb 100644 >--- a/Koha/Patrons.pm >+++ b/Koha/Patrons.pm >@@ -180,6 +180,13 @@ sub anonymise_issue_history { > > $older_than_date = dt_from_string $older_than_date if $older_than_date; > >+ my $filter_damaged = >+ C4::Context->preference("KeepDamagedCheckouts") || 0; >+ my $filter_lost = >+ C4::Context->preference("KeepLostCheckouts") || 0; >+ my $filter_withdrawn = >+ C4::Context->preference("KeepWithdrawnCheckouts") || 0; >+ > # The default of 0 does not work due to foreign key constraints > # The anonymisation should not fail quietly if AnonymousPatron is not a valid entry > # Set it to undef (NULL) >@@ -187,14 +194,20 @@ sub anonymise_issue_history { > my $nb_rows = 0; > while ( my $patron = $self->next ) { > my $old_issues_to_anonymise = $patron->old_checkouts->search( >- { >- ( >- $older_than_date >- ? ( returndate => >- { '<' => $dtf->format_datetime($older_than_date) } ) >- : () >- ) >- } >+ { >+ ( >+ $older_than_date >+ ? ( returndate => >+ { '<' => $dtf->format_datetime($older_than_date) } ) >+ : () >+ ), >+ ( $filter_damaged ? ( "itemnumber.damaged" => 0 ) : () ), >+ ( $filter_lost ? ( "itemnumber.itemlost" => 0 ) : () ), >+ ( $filter_withdrawn ? ( "itemnumber.withdrawn" => 0 ) : () ) >+ }, >+ { >+ join => ['itemnumber'] >+ } > ); > > my $last_borrowers_to_anonymise = >@@ -205,10 +218,10 @@ sub anonymise_issue_history { > ? ( created_on => > { '<' => $dtf->format_datetime($older_than_date) } ) > : (), >- "itemnumber.damaged" => 0, >- "itemnumber.itemlost" => 0, >- "itemnumber.withdrawn" => 0, >- ) >+ ), >+ ( $filter_damaged ? ( "itemnumber.damaged" => 0 ) : () ), >+ ( $filter_lost ? ( "itemnumber.itemlost" => 0 ) : () ), >+ ( $filter_withdrawn ? ( "itemnumber.withdrawn" => 0 ) : () ) > }, > { > join => ['itemnumber'] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23260
:
92863
|
92864
|
93052
|
94858
|
94859
|
95033
|
95457
|
95458
|
95459
|
95460
|
95651
|
95698
|
95699
|
95700
|
95701
|
95769
|
95770
|
95771
|
95772
|
96791
|
97841
|
97842
|
98044
|
98053
|
98054
|
98064
|
98282
|
98349
|
98352
|
112734
|
112735
|
112736
|
112737
|
112738
|
112739
|
112740
|
112741
|
112742
|
112743
|
117974
|
117975
|
117976
|
117977
|
117978
|
117979
|
117980
|
117981
|
117982
|
117983
|
120522
|
120523
|
120524
|
120525
|
120526
|
120527
|
120528
|
120529
|
120530
|
120531
|
122963
|
122964
|
122965
|
122966
|
122967
|
122968
|
122969
|
122970
|
122971
|
122972
|
145175
|
145176
|
145177
|
145178
|
145179
|
145180
|
145181
|
145182
|
145183
|
145184
|
157106
|
157107
|
157108
|
157109
|
157110
|
157111
|
157112
|
157113
|
157114
|
157115
|
157116
|
159291
|
159292
|
159293
|
159294
|
159298
|
159299
|
159300
|
159301
|
164129
|
164130
|
164131
|
164132
|
164133