Bugzilla – Attachment 98425 Details for
Bug 24587
reserve/placerequest.pl is not used anymore and should be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24587: Remove unused script reserve/placerequest.pl
Bug-24587-Remove-unused-script-reserveplacerequest.patch (text/plain), 5.82 KB, created by
Julian Maurice
on 2020-02-05 07:45:09 UTC
(
hide
)
Description:
Bug 24587: Remove unused script reserve/placerequest.pl
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2020-02-05 07:45:09 UTC
Size:
5.82 KB
patch
obsolete
>From b303396098ddb68d55272281db545fa978f03e46 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 5 Feb 2020 08:44:07 +0100 >Subject: [PATCH] Bug 24587: Remove unused script reserve/placerequest.pl > >Bug 19618 removed the last place where reserve/placerequest.pl was used >and forgot to remove it. >--- > reserve/placerequest.pl | 143 ---------------------------------------- > 1 file changed, 143 deletions(-) > delete mode 100755 reserve/placerequest.pl > >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >deleted file mode 100755 >index 89c591d55b..0000000000 >--- a/reserve/placerequest.pl >+++ /dev/null >@@ -1,143 +0,0 @@ >-#!/usr/bin/perl >- >-#script to place reserves/requests >-#written 2/1/00 by chris@katipo.oc.nz >- >- >-# Copyright 2000-2002 Katipo Communications >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use Modern::Perl; >- >-use CGI qw ( -utf8 ); >-use C4::Biblio; >-use C4::Items; >-use C4::Output; >-use C4::Reserves; >-use C4::Circulation; >-use C4::Members; >-use C4::Auth qw/checkauth/; >- >-use Koha::Items; >-use Koha::Patrons; >- >-my $input = CGI->new(); >- >-checkauth($input, 0, { reserveforothers => 'place_holds' }, 'intranet'); >- >-my @bibitems = $input->multi_param('biblioitem'); >-my @reqbib = $input->multi_param('reqbib'); >-my $biblionumber = $input->param('biblionumber'); >-my $borrowernumber = $input->param('borrowernumber'); >-my $notes = $input->param('notes'); >-my $branch = $input->param('pickup'); >-my $startdate = $input->param('reserve_date') || ''; >-my @rank = $input->multi_param('rank-request'); >-my $type = $input->param('type'); >-my $title = $input->param('title'); >-my $checkitem = $input->param('checkitem'); >-my $expirationdate = $input->param('expiration_date'); >-my $itemtype = $input->param('itemtype') || undef; >- >-my $borrower = Koha::Patrons->find( $borrowernumber ); >-$borrower = $borrower->unblessed if $borrower; >- >-my $multi_hold = $input->param('multi_hold'); >-my $biblionumbers = $multi_hold ? $input->param('biblionumbers') : ($biblionumber . '/'); >-my $bad_bibs = $input->param('bad_bibs'); >-my $holds_to_place_count = $input->param('holds_to_place_count') || 1; >- >-my %bibinfos = (); >-my @biblionumbers = split '/', $biblionumbers; >-foreach my $bibnum (@biblionumbers) { >- my %bibinfo = (); >- $bibinfo{title} = $input->param("title_$bibnum"); >- $bibinfo{rank} = $input->param("rank_$bibnum"); >- $bibinfos{$bibnum} = \%bibinfo; >-} >- >-my $found; >- >-if ( $type eq 'str8' && $borrower ) { >- >- foreach my $biblionumber ( keys %bibinfos ) { >- my $count = @bibitems; >- @bibitems = sort @bibitems; >- my $i2 = 1; >- my @realbi; >- $realbi[0] = $bibitems[0]; >- for ( my $i = 1 ; $i < $count ; $i++ ) { >- my $i3 = $i2 - 1; >- if ( $realbi[$i3] ne $bibitems[$i] ) { >- $realbi[$i2] = $bibitems[$i]; >- $i2++; >- } >- } >- >- my $can_override = C4::Context->preference('AllowHoldPolicyOverride'); >- if ( defined $checkitem && $checkitem ne '' ) { >- >- my $item = Koha::Items->find($checkitem); >- >- if ( $item->biblionumber ne $biblionumber ) { >- $biblionumber = $item->biblionumber; >- } >- >- my $can_item_be_reserved = CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status}; >- >- if ( $can_item_be_reserved eq 'OK' || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) ) { >- AddReserve( $branch, $borrower->{'borrowernumber'}, >- $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, >- $checkitem, $found, $itemtype ); >- } >- >- } elsif ($multi_hold) { >- my $bibinfo = $bibinfos{$biblionumber}; >- if ( $can_override || CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) { >- AddReserve($branch,$borrower->{'borrowernumber'},$biblionumber,[$biblionumber], >- $bibinfo->{rank},$startdate,$expirationdate,$notes,$bibinfo->{title},$checkitem,$found); >- } >- } else { >- # place a request on 1st available >- for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) { >- if ( $can_override || CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) { >- AddReserve( $branch, $borrower->{'borrowernumber'}, >- $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, >- $checkitem, $found, $itemtype ); >- } >- } >- } >- } >- >- if ($multi_hold) { >- if ($bad_bibs) { >- $biblionumbers .= $bad_bibs; >- } >- print $input->redirect("request.pl?biblionumbers=$biblionumbers&multi_hold=1"); >- } >- else { >- print $input->redirect("request.pl?biblionumber=$biblionumber"); >- } >-} >-elsif ( $borrowernumber eq '' ) { >- print $input->header(); >- print "Invalid borrower number please try again"; >- >- # Not sure that Dump() does HTML escaping. Use firebug or something to trace >- # instead. >- #print $input->Dump; >-} >-- >2.20.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=98425">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24587
: 98425