Attachment 98437 Details for Bug 24474 – Bug 24474: Add ReturnLostItem handling for SIP Payments

[patch] Bug 24474: Add ReturnLostItem handling for SIP Payments

Bug-24474-Add-ReturnLostItem-handling-for-SIP-Paym.patch (text/plain), 1.28 KB, created by Martin Renvoize (ashimema) on 2020-02-05 09:22:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-05 09:22:00 UTC

Size: 1.28 KB

patch

obsolete

>From ef1d6914a7064103a5a52217a9611f93d4ce7791 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 5 Feb 2020 09:16:02 +0000
>Subject: [PATCH] Bug 24474: Add ReturnLostItem handling for SIP Payments
>
>This patch adds a call to ReturnLostItem for Lost Item payments taken
>via SIP machines.
>---
> C4/SIP/ILS/Transaction/FeePayment.pm | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/C4/SIP/ILS/Transaction/FeePayment.pm b/C4/SIP/ILS/Transaction/FeePayment.pm
>index 7e19cc26df..40a318c918 100644
>--- a/C4/SIP/ILS/Transaction/FeePayment.pm
>+++ b/C4/SIP/ILS/Transaction/FeePayment.pm
>@@ -72,6 +72,20 @@ sub pay {
>                     interface    => C4::Context->interface
>                 }
>             );
>+           
>+            if ( $fee->debit_type_code eq 'LOST'
>+                && C4::Context->preference('MarkLostItemsAsReturned') =~
>+                m|OnPayment| )
>+            {
>+                $fee->get_from_storage;
>+                if (   $fee->amountoutstanding == 0
>+                    && $fee->itemnumber )
>+                {
>+                    C4::Circulation::ReturnLostItem( $self->{patron_id},
>+                        $fee->itemnumber );
>+                }
>+            }
>+
>             return 1;
>         }
>         else {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24474: 98392 | 98393 | 98436 | 98437 | 98438 | 98439 | 98460 | 98485 | 98486 | 98487 | 98645 | 98646 | 98647 | 98648 | 98673 | 98674 | 98675 | 98676 | 98923 | 100229 | 100230 | 100231 | 100232 | 100233 | 102104 | 102105 | 102106 | 102107 | 102108 | 102109 | 102110 | 102132 | 102133 | 102134 | 102135 | 102136 | 102137 | 102138