Bugzilla – Attachment 98461 Details for
Bug 24590
Koha/Object.t is failing on MySQL 8
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24590: Fix Koha/Object.t on MySQL 8
Bug-24590-Fix-KohaObjectt-on-MySQL-8.patch (text/plain), 1.50 KB, created by
Martin Renvoize (ashimema)
on 2020-02-05 12:31:04 UTC
(
hide
)
Description:
Bug 24590: Fix Koha/Object.t on MySQL 8
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-02-05 12:31:04 UTC
Size:
1.50 KB
patch
obsolete
>From f75c88abed4440a1cc4070b8e7198fdf43565b15 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 5 Feb 2020 10:36:14 +0100 >Subject: [PATCH] Bug 24590: Fix Koha/Object.t on MySQL 8 > >% prove t/db_dependent/Koha/Object.t >is failing on MySQL 8 with: > > kohadev-koha@9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t > t/db_dependent/Koha/Object.t .. 15/18 > # Failed test 'Exception field is correct' > # at t/db_dependent/Koha/Object.t line 650. > # got: 'api_keys.secret' > # expected: 'secret' > # Looks like you failed 1 test of 16. > t/db_dependent/Koha/Object.t .. 16/18 > # Failed test 'store() tests' > # at t/db_dependent/Koha/Object.t line 723. > >MySQL 8 displays the tablename in the error. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Object.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index 6679bd5567..4b7d0ce913 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -647,10 +647,10 @@ subtest 'store() tests' => sub { > 'Exception message is correct' > ); > >- is( >+ like( > $@->duplicate_id, >- 'secret', >- 'Exception field is correct' >+ qr/(api_keys\.)?secret/, >+ 'Exception field is correct (note that MySQL 8 is displaying the tablename)' > ); > > $schema->storage->dbh->{PrintError} = $print_error; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24590
:
98440
| 98461