Attachment 98476 Details for Bug 24584 – Bug 24584: Rewrite optional/sample_quotes to YAML

[patch] Bug 24584: Rewrite optional/sample_quotes to YAML

Bug-24584-Rewrite-optionalsamplequotes-to-YAML.patch (text/plain), 12.89 KB, created by Bernardo Gonzalez Kriegel on 2020-02-05 13:01:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2020-02-05 13:01:34 UTC

Size: 12.89 KB

patch

obsolete

>From d5e05d5b7ebace881193eb14710794dc032d6280 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Wed, 5 Feb 2020 09:51:16 -0300
>Subject: [PATCH] Bug 24584: Rewrite optional/sample_quotes to YAML
>
>YAML version of optional sample_quotes
>
>To test:
>1) Same test plan of first patch, only check table
>   quotes
>---
> .../data/mysql/en/optional/sample_quotes.sql  |  34 ----
> .../data/mysql/en/optional/sample_quotes.txt  |   1 -
> .../data/mysql/en/optional/sample_quotes.yml  | 154 ++++++++++++++++++
> 3 files changed, 154 insertions(+), 35 deletions(-)
> delete mode 100644 installer/data/mysql/en/optional/sample_quotes.sql
> delete mode 100644 installer/data/mysql/en/optional/sample_quotes.txt
> create mode 100644 installer/data/mysql/en/optional/sample_quotes.yml
>
>diff --git a/installer/data/mysql/en/optional/sample_quotes.sql b/installer/data/mysql/en/optional/sample_quotes.sql
>deleted file mode 100644
>index 9371dea5c1..0000000000
>--- a/installer/data/mysql/en/optional/sample_quotes.sql
>+++ /dev/null
>@@ -1,34 +0,0 @@
>-/*!40000 ALTER TABLE `quotes` DISABLE KEYS */;
>-INSERT INTO `quotes` VALUES
>-(1,'George Washington','To be prepared for war is one of the most effectual means of preserving peace.',now()),
>-(2,'Thomas Jefferson','When angry, count ten, before you speak; if very angry, an hundred.',now()),
>-(3,'Abraham Lincoln','Four score and seven years ago our fathers brought forth on this continent, a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal.',now()),
>-(4,'Abraham Lincoln','I have always found that mercy bears richer fruits than strict justice.',now()),
>-(5,'Andrew Johnson','I feel incompetent to perform duties...which have been so unexpectedly thrown upon me.',now()),
>-(6,'Rutherford B. Hayes','He serves his party best who serves his country best.',now()),
>-(7,'Theodore Roosevelt','No President has ever enjoyed himself as much as I?',now()),
>-(8,'Theodore Roosevelt','Speak softly and carry a big stick.',now()),
>-(9,'William H. Taft','I have come to the conclusion that the major part of the president is to increase the gate receipts of expositions and fairs and bring tourists to town.',now()),
>-(11,'Woodrow Wilson','You cannot become thorough Americans if you think of yourselves in groups. America does not consist of groups. A man who thinks of himself as belonging to a particular national group in America has not yet become an American.',now()),
>-(12,'Calvin Coolidge','If you don\'t say anything, you won\'t be called on to repeat it.',now()),
>-(13,'Calvin Coolidge','Four fifths of all our troubles in this life would disappear if we would only sit down and keep still.',now()),
>-(14,'Herbert Hoover','The slogan of progress is changing from the full dinner pail to the full garage.',now()),
>-(15,'Franklin D. Roosevelt','Let me assert my firm belief that the only thing we have to fear is fear itself.',now()),
>-(16,'Harry S. Truman','If you can\'t stand the heat, get out of the kitchen.',now()),
>-(17,'Harry S. Truman','The atom bomb was no great decision. It was merely another powerful weapon in the arsenal of righteousness.',now()),
>-(18,'Harry S. Truman','The buck stops here.',now()),
>-(19,'Dwight D. Eisenhower','History does not long entrust the care of freedom to the weak or the timid.',now()),
>-(20,'John F. Kennedy','My fellow Americans, ask not what your country can do for you; ask what you can do for your country.',now()),
>-(22,'John F. Kennedy','I do not think it altogether inappropriate to introduce myself to this audience. I am the man who accompanied Jacqueline Kennedy to Paris, and I have enjoyed it.',now()),
>-(23,'Lyndon B. Johnson','The Great Society is a place where every child can find knowledge to enrich his mind and to enlarge his talents. It is a place where the city of man serves not only the needs of the body and the demands of commerce but the desire for beauty and the hunger for community. It is a place where men are more concerned with the quality of their goals than the quantity of their goods.',now()),
>-(24,'Richard Nixon','People have got to know whether or not their president is a crook. Well, I\'m not a crook.',now()),
>-(25,'Richard Nixon','When the President does it, that means that it is not illegal.',now()),
>-(26,'Gerald R. Ford','Our Long national nightmare is over.',now()),
>-(27,'Gerald R. Ford','Our constitution works. Our great republic is a government of laws, not of men.',now()),
>-(28,'Jimmy Carter','A strong nation, like a strong person, can afford to be gentle, firm, thoughtful, and restrained. It can afford to extend a helping hand to others. It\'s a weak nation, like a weak person, that must behave with bluster and boasting and rashness and other signs of insecurity.',now()),
>-(30,'Ronald Reagan','It is not my intention to do away with government. It is rather to make it work -work with us, not over us; stand by our side, not ride on our back. Government can and must provide opportunity, not smother it; foster productivity, not stifle it. This Administration\'s objective will be a healthy, vigorous, growing economy.',now()),
>-(31,'Ronald Reagan','Each generation goes further than the generation preceding it because it stands on the shoulders of that generation. You will have opportunities beyond anything we\'ve ever known.',now()),
>-(32,'George H. W. Bush','We have ...drawn a line in the sand.',now()),
>-(33,'George W. Bush','If America shows weakness and uncertainty, the world will drift toward tragedy. That will not happen on my watch.',now()),
>-(34,'George W. Bush','Every nation in every region now has a decision to make. Either you are with us, or you are with the terrorists.',now());
>-/*!40000 ALTER TABLE `quotes` ENABLE KEYS */;
>diff --git a/installer/data/mysql/en/optional/sample_quotes.txt b/installer/data/mysql/en/optional/sample_quotes.txt
>deleted file mode 100644
>index 18ac7cf416..0000000000
>--- a/installer/data/mysql/en/optional/sample_quotes.txt
>+++ /dev/null
>@@ -1 +0,0 @@
>-Sample quotes
>diff --git a/installer/data/mysql/en/optional/sample_quotes.yml b/installer/data/mysql/en/optional/sample_quotes.yml
>new file mode 100644
>index 0000000000..1ea7d84a52
>--- /dev/null
>+++ b/installer/data/mysql/en/optional/sample_quotes.yml
>@@ -0,0 +1,154 @@
>+---
>+#
>+#  Copyright 2020 Koha Development Team
>+#
>+#  This file is part of Koha.
>+#
>+#  Koha is free software; you can redistribute it and/or modify it under the
>+#  terms of the GNU General Public License as published by the Free Software
>+#  Foundation; either version 2 of the License, or (at your option) any later
>+#  version.
>+#
>+#  Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+#  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+#  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+#  You should have received a copy of the GNU General Public License along
>+#  with Koha; if not, write to the Free Software Foundation, Inc.,
>+#  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+#
>+
>+description:
>+  - "Sample quotes"
>+
>+tables:
>+  - quotes:
>+      translatable: [ text ]
>+      multiline: []
>+      rows:
>+        - id: 1
>+          source: "George Washington"
>+          text: "To be prepared for war is one of the most effectual means of preserving peace."
>+
>+        - id: 2
>+          source: "Thomas Jefferson"
>+          text: "When angry, count ten, before you speak; if very angry, an hundred."
>+
>+        - id: 3
>+          source: "Abraham Lincoln"
>+          text: "Four score and seven years ago our fathers brought forth on this continent, a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal."
>+
>+        - id: 4
>+          source: "Abraham Lincoln"
>+          text: "I have always found that mercy bears richer fruits than strict justice."
>+
>+        - id: 5
>+          source: "Andrew Johnson"
>+          text: "I feel incompetent to perform duties...which have been so unexpectedly thrown upon me."
>+
>+        - id: 6
>+          source: "Rutherford B. Hayes"
>+          text: "He serves his party best who serves his country best."
>+
>+        - id: 7
>+          source: "Theodore Roosevelt"
>+          text: "No President has ever enjoyed himself as much as I?"
>+
>+        - id: 8
>+          source: "Theodore Roosevelt"
>+          text: "Speak softly and carry a big stick."
>+
>+        - id: 9
>+          source: "William H. Taft"
>+          text: "I have come to the conclusion that the major part of the president is to increase the gate receipts of expositions and fairs and bring tourists to town."
>+
>+        - id: 11
>+          source: "Woodrow Wilson"
>+          text: "You cannot become thorough Americans if you think of yourselves in groups. America does not consist of groups. A man who thinks of himself as belonging to a particular national group in America has not yet become an American."
>+
>+        - id: 12
>+          source: "Calvin Coolidge"
>+          text: "If you don't say anything, you won't be called on to repeat it."
>+
>+        - id: 13
>+          source: "Calvin Coolidge"
>+          text: "Four fifths of all our troubles in this life would disappear if we would only sit down and keep still."
>+
>+        - id: 14
>+          source: "Herbert Hoover"
>+          text: "The slogan of progress is changing from the full dinner pail to the full garage."
>+
>+        - id: 15
>+          source: "Franklin D. Roosevelt"
>+          text: "Let me assert my firm belief that the only thing we have to fear is fear itself."
>+
>+        - id: 16
>+          source: "Harry S. Truman"
>+          text: "If you can't stand the heat, get out of the kitchen."
>+
>+        - id: 17
>+          source: "Harry S. Truman"
>+          text: "The atom bomb was no great decision. It was merely another powerful weapon in the arsenal of righteousness."
>+
>+        - id: 18
>+          source: "Harry S. Truman"
>+          text: "The buck stops here."
>+
>+        - id: 19
>+          source: "Dwight D. Eisenhower"
>+          text: "History does not long entrust the care of freedom to the weak or the timid."
>+
>+        - id: 20
>+          source: "John F. Kennedy"
>+          text: "My fellow Americans, ask not what your country can do for you; ask what you can do for your country."
>+
>+        - id: 22
>+          source: "John F. Kennedy"
>+          text: "I do not think it altogether inappropriate to introduce myself to this audience. I am the man who accompanied Jacqueline Kennedy to Paris, and I have enjoyed it."
>+
>+        - id: 23
>+          source: "Lyndon B. Johnson"
>+          text: "The Great Society is a place where every child can find knowledge to enrich his mind and to enlarge his talents. It is a place where the city of man serves not only the needs of the body and the demands of commerce but the desire for beauty and the hunger for community. It is a place where men are more concerned with the quality of their goals than the quantity of their goods."
>+
>+        - id: 24
>+          source: "Richard Nixon"
>+          text: "People have got to know whether or not their president is a crook. Well, I'm not a crook."
>+
>+        - id: 25
>+          source: "Richard Nixon"
>+          text: "When the President does it, that means that it is not illegal."
>+
>+        - id: 26
>+          source: "Gerald R. Ford"
>+          text: "Our Long national nightmare is over."
>+
>+        - id: 27
>+          source: "Gerald R. Ford"
>+          text: "Our constitution works. Our great republic is a government of laws, not of men."
>+
>+        - id: 28
>+          source: "Jimmy Carter"
>+          text: "A strong nation, like a strong person, can afford to be gentle, firm, thoughtful, and restrained. It can afford to extend a helping hand to others. It's a weak nation, like a weak person, that must behave with bluster and boasting and rashness and other signs of insecurity."
>+
>+        - id: 30
>+          source: "Ronald Reagan"
>+          text: "It is not my intention to do away with government. It is rather to make it work -work with us, not over us; stand by our side, not ride on our back. Government can and must provide opportunity, not smother it; foster productivity, not stifle it. This Administration's objective will be a healthy, vigorous, growing economy."
>+
>+        - id: 31
>+          source: "Ronald Reagan"
>+          text: "Each generation goes further than the generation preceding it because it stands on the shoulders of that generation. You will have opportunities beyond anything we've ever known."
>+
>+        - id: 32
>+          source: "George H. W. Bush"
>+          text: "We have ...drawn a line in the sand."
>+
>+        - id: 33
>+          source: "George W. Bush"
>+          text: "If America shows weakness and uncertainty, the world will drift toward tragedy. That will not happen on my watch."
>+
>+        - id: 34
>+          source: "George W. Bush"
>+          text: "Every nation in every region now has a decision to make. Either you are with us, or you are with the terrorists."
>+
>+sql_statements:
>+  - "UPDATE quotes SET timestamp = NOW();"
>\ No newline at end of file
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 24584: 98464 | 98465 | 98466 | 98467 | 98468 | 98469 | 98470 | 98471 | 98472 | 98473 | 98474 | 98475 | 98476 | 98477 | 99402 | 99403 | 99404 | 99405 | 99406 | 99407 | 99408 | 99409 | 99410 | 99411 | 99412 | 99413 | 99414 | 99415 | 100352 | 100353 | 100354 | 100355 | 100356 | 100357 | 100358 | 100359 | 100360 | 100361 | 100362 | 100363 | 100364 | 100365