Attachment 98555 Details for Bug 24602 – Bug 24602: Make get_onshelfholds_policy fallback to 0

[patch] Bug 24602: Make get_onshelfholds_policy fallback to 0

Bug-24602-Make-getonshelfholdspolicy-fallback-to-0.patch (text/plain), 1.55 KB, created by David Nind on 2020-02-07 11:23:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-02-07 11:23:37 UTC

Size: 1.55 KB

patch

obsolete

>From 7d13d09af4cda3f63d1b8c788dff05cfb5f29beb Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 6 Feb 2020 11:10:39 -0300
>Subject: [PATCH] Bug 24602: Make get_onshelfholds_policy fallback to 0
>
>The onshelfholds circulation rules values are more of an ENUM type (as
>opposed to other rules with integers like max*qty). In the
>quantities cases, it makes sense to have undef mean unlimited. In the
>enum type it is clearer to just set a default value (0) as the code
>already expects (Note: undef and 0 both eval to false so there's no
>behaviour problem, but warnings or we get forced to check for
>defined when the rule is used. It seems trivial to just make the
>rule fallback to a chosen default value).
>
>This patch makes it fallback to 0.
>
>To test:
>1. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/CirculationRules.t \
>           t/db_dependent/Reserves.t
>=> FAIL: CirculationRules.t fails and Reserves.t prints a warning
>2. Apply this patch
>3. Repeat (1)
>=> SUCCESS: Tests pass! No warning!
>4. Sign off :-D
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/CirculationRules.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm
>index c26f572d12..6c36ba3b40 100644
>--- a/Koha/CirculationRules.pm
>+++ b/Koha/CirculationRules.pm
>@@ -420,7 +420,7 @@ sub get_onshelfholds_policy {
>             rule_name    => 'onshelfholds',
>         }
>     );
>-    return $rule ? $rule->rule_value : undef;
>+    return $rule ? $rule->rule_value : 0;
> }
> 
> =head3 article_requestable_rules
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24602: 98532 | 98533 | 98554 | 98555 | 98578 | 98579