Bugzilla – Attachment 98563 Details for
Bug 24611
Wrong budget_id query parameter in /acquisitions/orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24611: Fix wrong budget_id query param in /acquisitions/orders
Bug-24611-Fix-wrong-budgetid-query-param-in-acquis.patch (text/plain), 1.47 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-02-07 12:54:34 UTC
(
hide
)
Description:
Bug 24611: Fix wrong budget_id query param in /acquisitions/orders
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-02-07 12:54:34 UTC
Size:
1.47 KB
patch
obsolete
>From d563fc5bbbcb88cb1a90e4f491f715f352c42253 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 7 Feb 2020 09:51:10 -0300 >Subject: [PATCH] Bug 24611: Fix wrong budget_id query param in > /acquisitions/orders > >This patch fixes the wrong query parameter that slipped on rewriting the >patches for the voted RFC. > >To test: >1. Apply the tests patch >2. Run: > $ kshell > k$ prove t/db_dependent/api/v1/acquisitions_orders.t >=> FAIL: Tests fail because fund_id is not a valid query parameter >3. Apply this patch >4. Repeat (2) >=> SUCCESS: Tests pass! >5. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > api/v1/swagger/paths/acquisitions_orders.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/api/v1/swagger/paths/acquisitions_orders.json b/api/v1/swagger/paths/acquisitions_orders.json >index fc614dd49b..a0232d84b3 100644 >--- a/api/v1/swagger/paths/acquisitions_orders.json >+++ b/api/v1/swagger/paths/acquisitions_orders.json >@@ -26,9 +26,9 @@ > "type": "integer" > }, > { >- "name": "budget_id", >+ "name": "fund_id", > "in": "query", >- "description": "Identifier for the budget the order goes against", >+ "description": "Identifier for the fund the order goes against", > "required": false, > "type": "integer" > }, >-- >2.25.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24611
:
98562
|
98563
|
98592
|
98593
|
98822
|
98823