Attachment 98591 Details for Bug 23916 – Bug 23916: (follow-up) Fix column name collision

[patch] Bug 23916: (follow-up) Fix column name collision

Bug-23916-follow-up-Fix-column-name-collision.patch (text/plain), 2.03 KB, created by Bouzid Fergani on 2020-02-07 20:17:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bouzid Fergani

Created: 2020-02-07 20:17:40 UTC

Size: 2.03 KB

patch

obsolete

>From b75652c4a97aa86405851db238a0108d969f2eaf Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Mon, 18 Nov 2019 12:30:27 +0000
>Subject: [PATCH] Bug 23916: (follow-up) Fix column name collision
>
>Seems that joining 'borrowers' into the query run in
>C4::Members::GetAllIssues caused a column name collision, which blatted
>the retrieval of issues.branchcode. So we now are being a bit more
>specific in what is coming from where in the query.
>
>Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk>
>Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
>---
> C4/Members.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index c0e103c..9fbfc6f 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -274,7 +274,7 @@ sub GetAllIssues {
> 
>     my $dbh = C4::Context->dbh;
>     my $query =
>-'SELECT *, issues.timestamp as issuestimestamp, issues.renewals AS renewals,items.renewals AS totalrenewals,items.timestamp AS itemstimestamp
>+'SELECT issues.*, items.*, biblio.*, biblioitems.*, issues.timestamp as issuestimestamp, issues.renewals AS renewals,items.renewals AS totalrenewals,items.timestamp AS itemstimestamp,borrowers.firstname,borrowers.surname
>   FROM issues
>   LEFT JOIN items on items.itemnumber=issues.itemnumber
>   LEFT JOIN borrowers on borrowers.borrowernumber=issues.issuer
>@@ -282,7 +282,7 @@ sub GetAllIssues {
>   LEFT JOIN biblioitems ON items.biblioitemnumber=biblioitems.biblioitemnumber
>   WHERE issues.borrowernumber=?
>   UNION ALL
>-  SELECT *, old_issues.timestamp as issuestimestamp, old_issues.renewals AS renewals,items.renewals AS totalrenewals,items.timestamp AS itemstimestamp
>+  SELECT old_issues.*, items.*, biblio.*, biblioitems.*, old_issues.timestamp as issuestimestamp, old_issues.renewals AS renewals,items.renewals AS totalrenewals,items.timestamp AS itemstimestamp,borrowers.firstname,borrowers.surname
>   FROM old_issues
>   LEFT JOIN items on items.itemnumber=old_issues.itemnumber
>   LEFT JOIN borrowers on borrowers.borrowernumber=old_issues.issuer
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 23916: 94914 | 94915 | 94916 | 94917 | 94918 | 95503 | 95504 | 95505 | 95506 | 95507 | 95508 | 95509 | 97719 | 97720 | 97721 | 97722 | 97723 | 97724 | 98586 | 98587 | 98588 | 98589 | 98590 | 98591 | 98594 | 99886 | 99887 | 99888 | 99889 | 99890 | 99891 | 110649 | 110650 | 110651 | 110652 | 110653 | 110654 | 110655 | 111485 | 111486 | 111487 | 111488 | 111489 | 111490 | 111491 | 111492 | 111966 | 111967 | 111968 | 111969 | 111970 | 111971 | 111972 | 111973 | 111974 | 112248 | 112249 | 112250 | 112251 | 112252 | 112253 | 112254 | 112255 | 112256 | 112257 | 112363 | 112364 | 112365 | 112366 | 112367 | 112368 | 112369 | 112370 | 112371 | 112372 | 112373 | 113035 | 113036 | 113037 | 113038 | 113039 | 113040 | 113041 | 113042 | 113043 | 113044 | 113045 | 113316 | 113317 | 113318 | 113319 | 113320 | 113321 | 113322 | 113323 | 113324 | 113325 | 113326 | 113327 | 113367 | 113368 | 113369 | 113370 | 113371 | 113372 | 113373 | 113374 | 113375 | 113376 | 113377 | 113378 | 113379 | 113380 | 113381 | 113382 | 113396