Attachment 98594 Details for Bug 23916 – Bug 24495: Reword change collection feature

[patch] Bug 24495: Reword change collection feature

Bug-24495-Reword-change-collection-feature.patch (text/plain), 3.14 KB, created by Bouzid Fergani on 2020-02-07 21:13:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bouzid Fergani

Created: 2020-02-07 21:13:58 UTC

Size: 3.14 KB

patch

obsolete

>From 0e3f5bbf0f0b376e790e5d2f64e2b0151d894cdb Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Tue, 28 Jan 2020 00:21:19 +0000
>Subject: [PATCH] Bug 24495: Reword change collection feature
>
>This patch changes the text of the "Collect from patron" field to read "Amount tendered"
>
>To Test:
>
>1) In the Point of Sale screen, check that the text inside the "Collect payment" box reads "Collect from patron"
>2) Go into a patron record, and create a manual invoice.
>3) Go to Make a payment, and select to "Pay an amount". Check the text reads "Collect from patron".
>4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to the individual invoice)
>5) Install the patch
>6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of "Collect from patron" in all payment options in the patron record, and in the Point of Sale screen.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=23916
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt            | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>index ae2f53d..0a17c81 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
>@@ -116,7 +116,7 @@
>         <input name="paid" id="paid" value="[% amountoutstanding | $Price on_editing => 1 %]"/>
>     </li>
>     <li>
>-        <label for="collected">Collected from patron: </label>
>+        <label for="collected">Amount tendered: </label>
>         <input id="collected" value="[% amountoutstanding | $Price on_editing => 1 %]"/>
>     </li>
>     <li>
>@@ -250,7 +250,7 @@
> 
>     [% IF type != 'WRITEOFF' %]
>         <li>
>-            <label for="collected">Collected from patron: </label>
>+            <label for="collected">Amount tendered: </label>
>             <input id="collected" value="[% total | $Price on_editing => 1 %]"/>
>         </li>
>         <li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index 6f87d8b..edc13b0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -103,7 +103,7 @@
>                                 <input type="number" min="0.00" max="10000.00" step="0.01" name="paid" id="paid" value="[% amountoutstanding | $Price on_editing => 1 %]" readonly/>
>                             </li>
>                             <li>
>-                                <label for="collected">Collected from patron: </label>
>+                                <label for="collected">Amount tendered: </label>
>                                 <input type="number" min="0.00" max="10000.00" step="0.01" name="collected" id="collected" value=""/>
>                             </li>
>                             <li>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 23916: 94914 | 94915 | 94916 | 94917 | 94918 | 95503 | 95504 | 95505 | 95506 | 95507 | 95508 | 95509 | 97719 | 97720 | 97721 | 97722 | 97723 | 97724 | 98586 | 98587 | 98588 | 98589 | 98590 | 98591 | 98594 | 99886 | 99887 | 99888 | 99889 | 99890 | 99891 | 110649 | 110650 | 110651 | 110652 | 110653 | 110654 | 110655 | 111485 | 111486 | 111487 | 111488 | 111489 | 111490 | 111491 | 111492 | 111966 | 111967 | 111968 | 111969 | 111970 | 111971 | 111972 | 111973 | 111974 | 112248 | 112249 | 112250 | 112251 | 112252 | 112253 | 112254 | 112255 | 112256 | 112257 | 112363 | 112364 | 112365 | 112366 | 112367 | 112368 | 112369 | 112370 | 112371 | 112372 | 112373 | 113035 | 113036 | 113037 | 113038 | 113039 | 113040 | 113041 | 113042 | 113043 | 113044 | 113045 | 113316 | 113317 | 113318 | 113319 | 113320 | 113321 | 113322 | 113323 | 113324 | 113325 | 113326 | 113327 | 113367 | 113368 | 113369 | 113370 | 113371 | 113372 | 113373 | 113374 | 113375 | 113376 | 113377 | 113378 | 113379 | 113380 | 113381 | 113382 | 113396