Attachment 98609 Details for Bug 13305 – Bug 13305: Remove tabindex from PrepareItemsRecordDisplay

[patch] Bug 13305: Remove tabindex from PrepareItemsRecordDisplay

Bug-13305-Remove-tabindex-from-PrepareItemsRecordD.patch (text/plain), 4.33 KB, created by David Nind on 2020-02-08 05:59:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-02-08 05:59:09 UTC

Size: 4.33 KB

patch

obsolete

>From d36c7b123c2e6078a35358ecd1b7494cead68f4c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 20 Jan 2020 12:41:51 +0000
>Subject: [PATCH] Bug 13305: Remove tabindex from PrepareItemsRecordDisplay
>
>Test plan:
>Check the tab order of the item block on additem.pl (item editor),
>Acquisition (neworderempty or addiso2709), serials-edit.pl.
>You could also check services/itemrecorddisplay.pl and pass a
>biblionumber; this script is used in additem.js for cataloguing and
>acquisition.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/Items.pm | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 925afc2397..f832456821 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2542,17 +2542,17 @@ sub PrepareItemrecordDisplay {
>                         my $tab= $plugin->noclick? '-1': '';
>                         my $class= $plugin->noclick? ' disabled': '';
>                         my $title= $plugin->noclick? 'No popup': 'Tag editor';
>-                        $subfield_data{marc_value} = qq[<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" /><a href="#" id="buttonDot_$subfield_data{id}" tabindex="$tab" class="buttonDot $class" title="$title">...</a>\n].$plugin->javascript;
>+                        $subfield_data{marc_value} = qq[<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" /><a href="#" id="buttonDot_$subfield_data{id}" class="buttonDot $class" title="$title">...</a>\n].$plugin->javascript;
>                     } else {
>                         warn $plugin->errstr;
>                         $subfield_data{marc_value} = qq(<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />); # supply default input form
>                     }
>                 }
>                 elsif ( $tag eq '' ) {       # it's an hidden field
>-                    $subfield_data{marc_value} = qq(<input type="hidden" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />);
>+                    $subfield_data{marc_value} = qq(<input type="hidden" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />);
>                 }
>                 elsif ( $tagslib->{$tag}->{$subfield}->{'hidden'} ) {   # FIXME: shouldn't input type be "hidden" ?
>-                    $subfield_data{marc_value} = qq(<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />);
>+                    $subfield_data{marc_value} = qq(<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />);
>                 }
>                 elsif ( length($defaultvalue) > 100
>                             or (C4::Context->preference("marcflavour") eq "UNIMARC" and
>@@ -2561,9 +2561,9 @@ sub PrepareItemrecordDisplay {
>                                   500 <= $tag && $tag < 600                     )
>                           ) {
>                     # oversize field (textarea)
>-                    $subfield_data{marc_value} = qq(<textarea tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength">$defaultvalue</textarea>\n");
>+                    $subfield_data{marc_value} = qq(<textarea id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength">$defaultvalue</textarea>\n");
>                 } else {
>-                    $subfield_data{marc_value} = qq(<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />);
>+                    $subfield_data{marc_value} = qq(<input type="text" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />);
>                 }
>                 push( @loop_data, \%subfield_data );
>             }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 13305: 33731 | 97650 | 98609 | 98613