Attachment 9864 Details for Bug 7686 – Wrong tax calculation in reception summary page

[patch] Wrong tax calculation in reception summary page

0001-Tax-rate-calculation-in-reception-summary-page.patch (text/plain), 2.55 KB, created by Koha Team University Lyon 3 on 2012-05-31 15:56:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Koha Team University Lyon 3

Created: 2012-05-31 15:56:20 UTC

Size: 2.55 KB

patch

obsolete

>From 35eee7ddc7f21496de71d36ecf4c3661cd499bf1 Mon Sep 17 00:00:00 2001
>From: Lyon3 Team <koha@univ-lyon3.fr>
>Date: Thu, 31 May 2012 17:30:57 +0200
>Subject: [PATCH] Tax rate calculation in reception summary page
>
>In the Already received table, the total was wrong due to
>an erroneous calculation of tax rate
>---
> acqui/parcel.pl | 10 +++++++---
> .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 9 +++++++--
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
>diff --git a/acqui/parcel.pl b/acqui/parcel.pl
>index 5d0d164..714ef62 100755
>--- a/acqui/parcel.pl
>+++ b/acqui/parcel.pl
>@@ -295,7 +295,9 @@ if ($count>$resultsperpage){
> 
> #$totalfreight=$freight;
> $tototal = $tototal + $freight;
>-
>+my $gstreg = $bookseller->{gstreg};
>+my $gstpart = ($gstreg)? $tototal - ($tototal / ($gst + 1)) : $tototal * $gst;
>+my $grandtot = ($gstreg)? sprintf($cfstr, $tototal) : sprintf($cfstr, $tototal + $gstpart);
> $template->param(
> invoice => $invoice,
> datereceived => $datereceived->output('iso'),
>@@ -315,8 +317,10 @@ $template->param(
> totalquantity => $totalquantity,
> tototal => sprintf($cfstr, $tototal),
> ordergrandtotal => sprintf($cfstr, $ordergrandtotal),
>- gst => $gst,
>- grandtot => sprintf($cfstr, $tototal + $gst),
>+ gstpercent => sprintf( "%.2f", $gst * 100 ) . '%',
>+ gstpart => sprintf($cfstr,$gstpart),
>+ gstreg => $gstreg,
>+ grandtot => $grandtot,
> totalPunitprice => sprintf("%.2f", $totalPunitprice),
> totalPquantity => $totalPquantity,
> totalPqtyrcvd => $totalPqtyrcvd,
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>index a5d3e1a..ea967e3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>@@ -348,8 +348,13 @@
> 		 The total at the bottom of the page should be within a few cents of the total for the invoice.
> 		
> 		</td>
>-			 <td>Tax rate</td>
>-		<td>[% gst %]</td>
>+ [% IF ( gstreg ) %]
>+ <td>From which included 
>+ (tax rate [% gstpercent %])</td>
>+ [% ELSE %]
>+			 <td>Tax rate ([% gstpercent %])</td>
>+ [% END %]
>+		<td>[% gstpart %]</td>
> 	 	</tr> 
> 	 [% END %]
> 	 <tr>
>-- 
>1.7.2.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 7686: 8098 | 8099 | 9864 | 10132