Attachment 98674 Details for Bug 24474 – Bug 24474: Add `onpayment` option to `MarkLostItemsReturned`

[patch] Bug 24474: Add `onpayment` option to `MarkLostItemsReturned`

Bug-24474-Add-onpayment-option-to-MarkLostItemsRet.patch (text/plain), 3.15 KB, created by David Nind on 2020-02-10 16:53:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-02-10 16:53:38 UTC

Size: 3.15 KB

patch

obsolete

>From 0603edda59de9c8f1a64483196f8ab7a422ad391 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 5 Feb 2020 10:14:05 +0000
>Subject: [PATCH] Bug 24474: Add `onpayment` option to `MarkLostItemsReturned`
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> installer/data/mysql/atomicupdate/bug_24474.perl | 28 ++++++++++++++++++++++++
> installer/data/mysql/sysprefs.sql                |  2 +-
> 2 files changed, 29 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_24474.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_24474.perl b/installer/data/mysql/atomicupdate/bug_24474.perl
>new file mode 100644
>index 0000000000..c964d0c829
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_24474.perl
>@@ -0,0 +1,28 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if ( CheckVersion($DBversion) ) {
>+    $dbh->do(q{
>+        UPDATE
>+          systempreferences
>+        SET
>+          options = "batchmod|moredetail|cronjob|additem|pendingreserves|onpayment"
>+        WHERE
>+          variable = "MarkLostItemsAsReturned"
>+    });
>+
>+    my $lost_item_returned = C4::Context->preference("MarkLostItemsAsReturned");
>+    my @set = split( ",", $lost_item_returned );
>+    push @set, 'onpayment';
>+    $lost_item_returned = join( ",", @set );
>+
>+    $dbh->do(qq{
>+        UPDATE
>+          systempreferences
>+        SET
>+          value = "$lost_item_returned"
>+        WHERE
>+          variable = "MarkLostItemsAsReturned"
>+    });
>+
>+    SetVersion($DBversion);
>+    print "Upgrade to $DBversion done (Bug 24474 - Add `onpayment` option to MarkLostItemsAsReturned)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index cfa295e197..c463d81a6b 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -306,7 +306,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('MarcFieldForModifierName','',NULL,'Where to store the name of the record''s last modifier','Free'),
> ('MarcFieldsToOrder','',NULL,'Set the mapping values for a new order line created from a MARC record in a staged file. In a YAML format.','textarea'),
> ('MarcItemFieldsToOrder','',NULL,'Set the mapping values for new item records created from a MARC record in a staged file. In a YAML format.','textarea'),
>-('MarkLostItemsAsReturned','batchmod,moredetail,cronjob,additem,pendingreserves','batchmod|moredetail|cronjob|additem|pendingreserves','Mark items as returned when flagged as lost','multiple'),
>+('MarkLostItemsAsReturned','batchmod,moredetail,cronjob,additem,pendingreserves,onpayment','batchmod|moredetail|cronjob|additem|pendingreserves|onpayment','Mark items as returned when flagged as lost','multiple'),
> ('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records - http://www.loc.gov/marc/organizations/orgshome.html','free'),
> ('MaxFine',NULL,'','Maximum fine a patron can have for all late returns at one moment. Single item caps are specified in the circulation rules matrix.','Integer'),
> ('MaxItemsToDisplayForBatchDel','1000',NULL,'Display up to a given number of items in a single item deletionbatch.','Integer'),
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24474: 98392 | 98393 | 98436 | 98437 | 98438 | 98439 | 98460 | 98485 | 98486 | 98487 | 98645 | 98646 | 98647 | 98648 | 98673 | 98674 | 98675 | 98676 | 98923 | 100229 | 100230 | 100231 | 100232 | 100233 | 102104 | 102105 | 102106 | 102107 | 102108 | 102109 | 102110 | 102132 | 102133 | 102134 | 102135 | 102136 | 102137 | 102138