Bugzilla – Attachment 9871 Details for
Bug 7599
Cart JavaScript contains untranslatable English strings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings
Bug-7599---SIGNED-OFF-Cart-JavaScript-contains-unt.patch (text/plain), 4.15 KB, created by
Jonathan Druart
on 2012-06-01 09:21:58 UTC
(
hide
)
Description:
Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-06-01 09:21:58 UTC
Size:
4.15 KB
patch
obsolete
>From 9a3a693f13887c478bea8fc4e822cb6ddd19b1e0 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 22 May 2012 14:42:42 -0400 >Subject: [PATCH] Bug 7599 - [SIGNED-OFF] Cart JavaScript contains > untranslatable English strings > >To simplify the sentence structure for better translation flexibility >the message now reads: > >"Item in your cart: " + number > >Fixed in both OPAC and staff client, although I'm not sure >the message is actually triggered in the staff client. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Strings become translatable >--- > .../prog/en/includes/doc-head-close.inc | 1 + > koha-tmpl/intranet-tmpl/prog/en/js/basket.js | 4 ++-- > .../opac-tmpl/prog/en/includes/doc-head-close.inc | 1 + > koha-tmpl/opac-tmpl/prog/en/js/basket.js | 4 ++-- > 4 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >index 116d2e1..4d83a5b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >@@ -57,6 +57,7 @@ > var MSG_NO_RECORD_ADDED = _("No item was added to your cart"); > var MSG_CONFIRM_DEL_BASKET = _("Are you sure you want to empty your cart?"); > var MSG_CONFIRM_DEL_RECORDS = _("Are you sure you want to remove the selected items?"); >+ var MSG_IN_YOUR_CART = _("Items in your cart: "); > var MSG_NON_RESERVES_SELECTED = _("One or more selected items cannot be reserved."); > [% END %] > //]]> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >index 5b96c12..2043cd6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >@@ -378,10 +378,10 @@ function showLess() { > function updateBasket(updated_value,target) { > if(target){ > target.$('#basketcount').html(" <span>("+updated_value+")</span>"); >- target.$('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); >+ target.$('#cartDetails').html(MSG_IN_YOUR_CART+updated_value); > } else { > $('#basketcount').html(" <span>("+updated_value+")</span>"); >- $('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); >+ $('#cartDetails').html(MSG_IN_YOUR_CART+updated_value); > } > var basketcount = updated_value; > } >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >index 3907f34..53a43c1 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >@@ -56,6 +56,7 @@ > var MSG_CONFIRM_DEL_BASKET = _("Are you sure you want to empty your cart?"); > var MSG_CONFIRM_DEL_RECORDS = _("Are you sure you want to remove the selected items?"); > var MSG_ITEM_IN_CART = _("In your cart"); >+ var MSG_IN_YOUR_CART = _("Items in your cart: "); > var MSG_ITEM_NOT_IN_CART = _("Add to your cart"); > $("#cartDetails").ready(function(){ $("#cmspan").html("<a href=\"#\" id=\"cartmenulink\" class=\"\"><i><\/i><span><i><\/i><span><\/span><span id=\"carticon\"></span> "+_("Cart")+"<span id=\"basketcount\"><\/span><\/span><\/a>"); }); [% ELSE %][% IF ( virtualshelves ) %] > var MSG_NO_RECORD_SELECTED = _("No item was selected");[% END %][% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/js/basket.js b/koha-tmpl/opac-tmpl/prog/en/js/basket.js >index 1872ff3..13a2c36 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/js/basket.js >+++ b/koha-tmpl/opac-tmpl/prog/en/js/basket.js >@@ -400,10 +400,10 @@ function showLess() { > function updateBasket(updated_value,target) { > if(target){ > target.$('#basketcount').html("<span>"+updated_value+"</span>"); >- target.$('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); >+ target.$('#cartDetails').html(MSG_IN_YOUR_CART+updated_value); > } else { > $('#basketcount').html("<span>"+updated_value+"</span>"); >- $('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); >+ $('#cartDetails').html(MSG_IN_YOUR_CART+updated_value); > } > var basketcount = updated_value; > } >-- >1.7.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7599
:
9710
| 9871