Bugzilla – Attachment 98712 Details for
Bug 8643
Add ability to mark some MARC tags and subfields as important and alert on saving the record if they are found to be empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8643: Fix IsMarcStructureInternal tests
Bug-8643-Fix-IsMarcStructureInternal-tests.patch (text/plain), 1.96 KB, created by
Jonathan Druart
on 2020-02-11 15:44:54 UTC
(
hide
)
Description:
Bug 8643: Fix IsMarcStructureInternal tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-11 15:44:54 UTC
Size:
1.96 KB
patch
obsolete
>From d3ebcb37f0c87badfb56a1c5b3a876281c69915e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 11 Feb 2020 16:44:07 +0100 >Subject: [PATCH] Bug 8643: Fix IsMarcStructureInternal tests > >--- > C4/Biblio.pm | 2 +- > t/db_dependent/Biblio.t | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 700dc1cb77..aa401d5646 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -824,7 +824,7 @@ sub GetISBDView { > # Process subfield > } > >-GetMarcStructure creates keys (lib, tab, mandatory, repeatable) for a display purpose. >+GetMarcStructure creates keys (lib, tab, mandatory, repeatable, important) for a display purpose. > These different values should not be processed as valid subfields. > > =cut >diff --git a/t/db_dependent/Biblio.t b/t/db_dependent/Biblio.t >index cc38e07201..ab1553b81c 100755 >--- a/t/db_dependent/Biblio.t >+++ b/t/db_dependent/Biblio.t >@@ -554,7 +554,7 @@ subtest 'NORMARC' => sub { > }; > > subtest 'IsMarcStructureInternal' => sub { >- plan tests => 8; >+ plan tests => 9; > my $tagslib = GetMarcStructure(); > my @internals; > for my $tag ( sort keys %$tagslib ) { >@@ -564,11 +564,12 @@ subtest 'IsMarcStructureInternal' => sub { > } > } > @internals = uniq @internals; >- is( scalar(@internals), 6, 'expect 6 internals'); >+ is( scalar(@internals), 7, 'expect 7 internals'); > is( grep( /^lib$/, @internals ), 1, 'check lib' ); > is( grep( /^tab$/, @internals ), 1, 'check tab' ); > is( grep( /^mandatory$/, @internals ), 1, 'check mandatory' ); > is( grep( /^repeatable$/, @internals ), 1, 'check repeatable' ); >+ is( grep( /^important$/, @internals ), 1, 'check important' ); > is( grep( /^a$/, @internals ), 0, 'no subfield a' ); > is( grep( /^ind1_defaultvalue$/, @internals ), 1, 'check indicator 1 default value' ); > is( grep( /^ind2_defaultvalue$/, @internals ), 1, 'check indicator 2 default value' ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8643
:
11621
|
11622
|
30640
|
31032
|
40232
|
40237
|
41259
|
41261
|
41264
|
41265
|
45834
|
45835
|
45836
|
45837
|
60554
|
60555
|
65148
|
65149
|
65682
|
72154
|
72155
|
72156
|
72157
|
73591
|
73808
|
73809
|
73810
|
73811
|
73812
|
73813
|
73814
|
73815
|
73816
|
73817
|
73818
|
74267
|
74268
|
74269
|
74270
|
74271
|
74272
|
74273
|
81032
|
85982
|
91537
|
92081
|
92384
|
96625
|
96627
|
97325
|
97326
|
98607
|
98608
|
98702
|
98703
| 98712