Attachment 98714 Details for Bug 24614 – Bug 24614: Add tests

[patch] Bug 24614: Add tests

Bug-24614-Add-tests.patch (text/plain), 1.28 KB, created by Jonathan Druart on 2020-02-11 16:25:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-02-11 16:25:11 UTC

Size: 1.28 KB

patch

obsolete

>From 07b784ebf988cfab581dce931ae46440d0d45567 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 11 Feb 2020 17:21:15 +0100
>Subject: [PATCH] Bug 24614: Add tests
>
>---
> t/db_dependent/Reports/Guided.t | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Reports/Guided.t b/t/db_dependent/Reports/Guided.t
>index 0d8d01d15c..bb832af84d 100644
>--- a/t/db_dependent/Reports/Guided.t
>+++ b/t/db_dependent/Reports/Guided.t
>@@ -181,7 +181,7 @@ subtest 'GetParametersFromSQL+ValidateSQLParameters' => sub  {
> };
> 
> subtest 'get_saved_reports' => sub {
>-    plan tests => 16;
>+    plan tests => 17;
>     my $dbh = C4::Context->dbh;
>     $dbh->do(q|DELETE FROM saved_sql|);
>     $dbh->do(q|DELETE FROM saved_reports|);
>@@ -216,6 +216,10 @@ subtest 'get_saved_reports' => sub {
> 
>     ok( 0 < scalar @{ get_saved_reports( $report_ids[0] ) }, "filter takes report id" );
> 
>+    my $r1 = Koha::Reports->find($report_ids[0]);
>+    $r1 = update_sql($r1->id, { borrowernumber => $r1->borrowernumber, name => 'Just another report' });
>+    is( $r1->cache_expiry, 300, 'cache_expiry has the correct default value, from DBMS' );
>+
>     #Test delete_report
>     is (delete_report(),undef, "Without id delete_report returns undef");
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24614: 98714 | 98715 | 101700 | 101701 | 101764 | 101765 | 102013