Attachment 98746 Details for Bug 19735 – Bug 19735: (QA follow-up) Drop references to 'usage'

[patch] Bug 19735: (QA follow-up) Drop references to 'usage'

Bug-19735-QA-follow-up-Drop-references-to-usage.patch (text/plain), 2.20 KB, created by Jonathan Druart on 2020-02-12 13:33:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-02-12 13:33:27 UTC

Size: 2.20 KB

patch

obsolete

>From ec484e9856bfec315d1080adf04f1edad5450b0c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 7 Feb 2020 16:59:44 +0000
>Subject: [PATCH] Bug 19735: (QA follow-up) Drop references to 'usage'
>
>The 'usage' key was dropped as part of this migration to cpanfile but
>it was still refered to by the installed. This patch simply removes
>references to it. After considering how we might add it back in I
>decided that as it stands it wasn't a well maintained list and should be
>re-implimented in the future in a more consistent form if we miss it.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> installer/install.pl | 3 +--
> koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/installer/install.pl b/installer/install.pl
>index 0b2a683a2d..c9e119d6bc 100755
>--- a/installer/install.pl
>+++ b/installer/install.pl
>@@ -112,8 +112,7 @@ if ( $step && $step == 1 ) {
> {
> name => $module,
> version => $stats->{'min_ver'},
>- require => $stats->{'required'},
>- usage => $stats->{'usage'},
>+ require => $stats->{'required'}
> }
> );
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
>index 649d8663d9..339af4fff3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
>@@ -62,7 +62,6 @@
> [% FOREACH missing_module IN missing_modules %]
> <li>[% missing_module.name | html %] [% IF ( missing_module.require ) %]Required[% END %]
> Version: [% missing_module.version | html %]
>- Usage: [% missing_module.usage | html %]
> </li>
> [% END %]
> </ul>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19735: 69465 | 69466 | 73837 | 73838 | 81612 | 97484 | 97485 | 98568 | 98569 | 98570 | 98576 | 98577 | 98636 | 98637 | 98638 | 98639 | 98640 | 98743 | 98744 | 98745 | 98746 | 98747 | 98748