Bugzilla – Attachment 98755 Details for
Bug 24642
Cache::Memcached::Fast::Safe must be marked as mandatory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24642: Make Cache::Memcached::Fast::Safe required
Bug-24642-Make-CacheMemcachedFastSafe-required.patch (text/plain), 1.32 KB, created by
Jonathan Druart
on 2020-02-12 14:26:35 UTC
(
hide
)
Description:
Bug 24642: Make Cache::Memcached::Fast::Safe required
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-12 14:26:35 UTC
Size:
1.32 KB
patch
obsolete
>From bd74e2bc22ff57c9ce6bb7c740d7d7ff2c57cec0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 12 Feb 2020 15:24:35 +0100 >Subject: [PATCH] Bug 24642: Make Cache::Memcached::Fast::Safe required > >There is something wrong between the logic in Koha::Cache->new and our dependencies. > >We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. >However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. > >We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). > >Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. >--- > C4/Installer/PerlDependencies.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm >index 9f1db97be7..5c1acfc7c5 100644 >--- a/C4/Installer/PerlDependencies.pm >+++ b/C4/Installer/PerlDependencies.pm >@@ -264,7 +264,7 @@ our $PERL_DEPS = { > }, > 'Cache::Memcached::Fast::Safe' => { > 'usage' => 'Caching', >- 'required' => '0', >+ 'required' => '1', > 'min_ver' => '0.06' > }, > 'Cache::FastMmap' => { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24642
:
98755
|
98756
|
98761