Bugzilla – Attachment 98802 Details for
Bug 23975
Add ability to search and install plugins from GitHub
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23975: (follow-up) Don't rely on save_to being present
Bug-23975-follow-up-Dont-rely-on-saveto-being-pres.patch (text/plain), 1.09 KB, created by
David Nind
on 2020-02-13 10:06:10 UTC
(
hide
)
Description:
Bug 23975: (follow-up) Don't rely on save_to being present
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-02-13 10:06:10 UTC
Size:
1.09 KB
patch
obsolete
>From 540c83e4d1ec1bc60e6de6917b9564946c8b785f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 13 Feb 2020 08:48:17 +0000 >Subject: [PATCH] Bug 23975: (follow-up) Don't rely on save_to being present > >The `save_to` shortcut method was introduced to Mojolicious in version >8.02 but we still support 7.21 as our minimum dependancy and as such we >cannot yet use it. > >Signed-off-by: David Nind <david@davidnind.com> >--- > plugins/plugins-upload.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/plugins/plugins-upload.pl b/plugins/plugins-upload.pl >index 7f873fa4fd..90b8730406 100755 >--- a/plugins/plugins-upload.pl >+++ b/plugins/plugins-upload.pl >@@ -75,7 +75,7 @@ if ($plugins_enabled) { > if ( $uploadlocation ) { > my $ua = Mojo::UserAgent->new(max_redirects => 5); > my $tx = $ua->get($uploadlocation); >- $tx->result->save_to($tempfile); >+ $tx->result->content->asset->move_to($tempfile); > } else { > $errors{'EMPTYUPLOAD'} = 1 unless ( length($uploadfile) > 0 ); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23975
:
95067
|
98757
|
98758
|
98791
|
98792
|
98793
|
98800
|
98801
|
98802
|
98813
|
98814
|
98815
|
99958
|
99970
|
99971
|
99972
|
99973
|
99974
|
99975