Attachment 98810 Details for Bug 6508 – Bug 6508: (follow-up) Change layout of price and hide tab if no fines

[patch] Bug 6508: (follow-up) Change layout of price and hide tab if no fines

Bug-6508-follow-up-Change-layout-of-price-and-hide.patch (text/plain), 2.06 KB, created by David Nind on 2020-02-13 11:07:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-02-13 11:07:13 UTC

Size: 2.06 KB

patch

obsolete

>From 10d03992e3aed971c9f99ced28c5edd91bf24833 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Thu, 13 Feb 2020 04:24:08 +0000
>Subject: [PATCH] Bug 6508: (follow-up) Change layout of price and hide tab if
> no fines
>
>With this patch, the tab will not show if there are no fines.
>I've also changed how the fines look in the tab header to look more like
>the OPAC fines tab.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index f40dd4c92d..ced24808dc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -699,8 +699,8 @@
>                                     <a href="#relatives-issues" id="relatives-issues-tab">[% relatives_issues_count | html %] Relatives' checkouts</a>
>                                 </li>
>                             [% END %]
>-                            <li>
>-                                <a href="#finesandcharges">[% fines | $Price %] Fines &amp; Charges</a>
>+                            <li id="finestab">
>+                                <a href="#finesandcharges">Fines &amp; Charges ([% fines | $Price %])</a>
>                             </li>
>                             [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
>                                 <li>
>@@ -888,6 +888,11 @@
>         columns_settings_issues_table = [% ColumnsSettings.GetColumns( 'members', 'moremember', 'issues-table', 'json' ) | $raw %]
> 
>         $(document).ready(function() {
>+            $("#finestab").hide();
>+            [% IF fines %]
>+                $("#finestab").show();
>+            [% END %]
>+
>             if ( $('#clubs-tab').length ) {
>                 $('#clubs-tab-link').on('click', function() {
>                     $('#clubs-tab').text(_("Loading..."));
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 6508: 4487 | 94601 | 98786 | 98787 | 98809 | 98810 | 98972 | 98973 | 98974 | 99004 | 99005 | 99006