Attachment 98842 Details for Bug 23355 – Bug 23355: Add cashup permissions

[patch] Bug 23355: Add cashup permissions

Bug-23355-Add-cashup-permissions.patch (text/plain), 3.42 KB, created by Martin Renvoize (ashimema) on 2020-02-13 14:37:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-13 14:37:48 UTC

Size: 3.42 KB

patch

obsolete

>From 424ee3d52ee21f744672b6bd35c3c11c5991e9a8 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 13 Sep 2019 14:48:49 +0100
>Subject: [PATCH] Bug 23355: Add cashup permissions
>
>Add new 'cashup' sub-permissions to the 'cash_management' permission to
>allow fine grained control over whome may 'cashup' a cash register.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../mysql/atomicupdate/bug_23355_permissions.perl    | 12 ++++++++++++
> installer/data/mysql/userpermissions.sql             |  1 +
> .../intranet-tmpl/prog/en/includes/permissions.inc   |  5 +++++
> .../intranet-tmpl/prog/en/includes/pos-menu.inc      |  2 +-
> 4 files changed, 19 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_23355_permissions.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_23355_permissions.perl b/installer/data/mysql/atomicupdate/bug_23355_permissions.perl
>new file mode 100644
>index 0000000000..15251c0bb6
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_23355_permissions.perl
>@@ -0,0 +1,12 @@
>+$DBversion = 'XXX';    # will be replaced by the RM
>+if ( CheckVersion($DBversion) ) {
>+
>+    $dbh->do(qq{
>+        INSERT IGNORE permissions (module_bit, code, description)
>+        VALUES
>+        (25, 'cashup', 'Perform cash register cashup action')
>+    });
>+
>+    SetVersion($DBversion);
>+    print "Upgrade to $DBversion done (Bug 23355 - Add cash register cashup permissions)\n";
>+}
>diff --git a/installer/data/mysql/userpermissions.sql b/installer/data/mysql/userpermissions.sql
>index 136c7b16bc..bad1b9ad44 100644
>--- a/installer/data/mysql/userpermissions.sql
>+++ b/installer/data/mysql/userpermissions.sql
>@@ -121,5 +121,6 @@ INSERT INTO permissions (module_bit, code, description) VALUES
>    (23, 'self_checkout_module', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID'),
>    (24, 'manage_rotas', 'Create, edit and delete rotas'),
>    (24, 'manage_rota_items', 'Add and remove items from rotas'),
>+   (25, 'cashup', 'Perform cash register cashup action'),
>    (25, 'takepayment', 'Access the point of sale page and take payments')
> ;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>index 3f7cb441c1..1e678c7dae 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>@@ -699,5 +699,10 @@
>             Access the point of sale page and take payments
>         </span>
>         <span class="permissioncode">([% name | html %])</span>
>+    [%- CASE 'cashup' -%]
>+        <span class="sub_permission cashup_subpermission">
>+            Perform cash register cashup action
>+        </span>
>+        <span class="permissioncode">([% name | html %])</span>
>   [%- END -%]
> [%- END -%]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/pos-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/pos-menu.inc
>index 85fd3b0634..bf3e75ba8f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/pos-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/pos-menu.inc
>@@ -1,6 +1,6 @@
> <div id="navmenu">
>     <div id="navmenulist">
>-        [% IF ( CAN_user_cash_management_cashup_cash_registers ) %]
>+        [% IF ( CAN_user_cash_management_cashup ) %]
>         <h5>Point of sale</h5>
>         <ul>
>             <li><a href="/cgi-bin/koha/pos/register.pl">Register details</a></li>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23355: 92941 | 92942 | 92943 | 92944 | 92945 | 92946 | 92947 | 92948 | 92949 | 92950 | 92951 | 92952 | 92953 | 97031 | 97032 | 97033 | 97034 | 97035 | 97036 | 97037 | 97038 | 97039 | 97040 | 97041 | 97043 | 97044 | 97045 | 97046 | 97047 | 97048 | 97049 | 97050 | 97051 | 97052 | 97053 | 97054 | 97077 | 97078 | 97079 | 97080 | 97081 | 97082 | 97083 | 97084 | 97085 | 97086 | 97087 | 97088 | 97089 | 97706 | 97707 | 97708 | 97709 | 97710 | 97711 | 97712 | 97713 | 97714 | 97715 | 97716 | 97784 | 97785 | 97786 | 97787 | 97788 | 97789 | 97790 | 97791 | 97792 | 97793 | 97794 | 97816 | 97817 | 97818 | 97819 | 97820 | 97821 | 97822 | 97823 | 98026 | 98027 | 98028 | 98835 | 98836 | 98837 | 98838 | 98839 | 98840 | 98841 | 98842 | 100009 | 100010 | 100011 | 100012 | 100013 | 100014 | 100015 | 100016 | 100017 | 100018 | 100019 | 100020 | 100021 | 100030 | 100090 | 101685