Attachment 98882 Details for Bug 22898 – Bug 22898: Fix failure since bug 19618

[patch] Bug 22898: Fix failure since bug 19618

Bug-22898-Fix-failure-since-bug-19618.patch (text/plain), 1.73 KB, created by Martin Renvoize (ashimema) on 2020-02-13 17:03:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-13 17:03:17 UTC

Size: 1.73 KB

patch

obsolete

>From 3fed2158b465ba262e51821852ac3e5174e151b7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 21 Jan 2020 12:57:01 +0100
>Subject: [PATCH] Bug 22898: Fix failure since bug 19618
>
>See comment in the code, this is not the correct fix, but cannot find
>something better for now.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/selenium/basic_workflow.t | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t
>index 7a87827910..62dcf0e470 100644
>--- a/t/db_dependent/selenium/basic_workflow.t
>+++ b/t/db_dependent/selenium/basic_workflow.t
>@@ -237,12 +237,14 @@ SKIP: {
>     #Place holds
>     $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[0]);
>     $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click; # Biblio level
>+    $driver->pause(1000); # This seems wrong, since bug 19618 the hold is created async with an AJAX call. Not sure what is happening here but the next statements are exectuted before the hold is created and the count is wrong (still 0)
>     my $patron = Koha::Patrons->find($borrowernumber);
>     is( $patron->holds->count, 1, );
> 
>     $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[1]);
>     $driver->find_element('//form[@id="hold-request-form"]//input[@type="radio"]')->click; # Item level, there is only 1 item per bib so we are safe
>     $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click;
>+    $driver->pause(1000);
>     is( $patron->holds->count, 2, );
> 
>     time_diff("holds");
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22898: 89673 | 90208 | 90241 | 97655 | 97656 | 98877 | 98878 | 98879 | 98880 | 98881 | 98882