Attachment 98887 Details for Bug 24649 – Bug 24649: Fix missing <li> tag on item editor for cloned subfield

[patch] Bug 24649: Fix missing <li> tag on item editor for cloned subfield

Bug-24649-Fix-missing-li-tag-on-item-editor-for-cl.patch (text/plain), 1.70 KB, created by Aleisha Amohia on 2020-02-13 20:16:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2020-02-13 20:16:46 UTC

Size: 1.70 KB

patch

obsolete

>From db37ec4af3a7db1fa05e4e582a44aa15931cb750 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 13 Feb 2020 08:56:35 +0000
>Subject: [PATCH] Bug 24649: Fix missing <li> tag on item editor for cloned
> subfield
>
>Instead of the parentNode (which is a div), we need the parent of the div
>(which is a li).
>So a simple fix.
>
>Test plan:
>To see the difference, test first without patch applied:
>Mark item subfield, say URI, as repeatable.
>Clone that subfield in item editor.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 74c659f..9862aa4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -198,7 +198,7 @@
>                 <input type="hidden" name="mandatory" value="[% ite.mandatory | html %]" />
>                 <input type="hidden" name="important" value="[% ite.important | html %]" />
>                 [% IF ( ite.repeatable ) %]
>-                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode); return false;">
>+                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">
>                         <img src="[% interface | html %]/[% theme | html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
>                     </a>
>                 [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 24649: 98794 | 98795 | 98797 | 98798 | 98829 | 98887 | 98888 | 98949 | 98958 | 98959