Attachment 98959 Details for Bug 24649 – Bug 24649: Fix two other missing <li> tags for cloned subfields

[patch] Bug 24649: Fix two other missing <li> tags for cloned subfields

Bug-24649-Fix-two-other-missing-li-tags-for-cloned.patch (text/plain), 3.67 KB, created by Katrin Fischer on 2020-02-14 14:56:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-02-14 14:56:16 UTC

Size: 3.67 KB

patch

obsolete

>From 7036c0dd9bc4b0346c3adeb86cf8634c2caf90a1 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 13 Feb 2020 09:27:26 +0000
>Subject: [PATCH] Bug 24649: Fix two other missing <li> tags for cloned
> subfields
>
>Same problem as previous patch in Batch item modification as well as
>serial-edit.pl.
>
>Test plan:
>[1] Go to Tools/Batch item modification.
>    Test cloning subfield on batchMod-edit.
>[2] Go to a serial with "Create item when receiving".
>    Receive an issue. Click add item.
>    Test cloning subfield.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt  | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>index 297967cc30..8fe16b99fb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>@@ -252,7 +252,7 @@ $(document).ready(function() {
>                 <input type="hidden" name="subfield" value="[% iteminformatio.subfield | html %]" />
>                 <input type="hidden" name="mandatory" value="[% iteminformatio.mandatory | html %]" />
>                 [% IF ( iteminformatio.repeatable ) %]
>-                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode); return false;">
>+                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">
>                         <img src="[% interface | html %]/[% theme | html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
>                     </a>
>                 [% END %]
>@@ -404,7 +404,7 @@ $(document).ready(function() {
>                 <input type="hidden" name="subfield" value="[% iteminformatio.subfield | html %]" />
>                 <input type="hidden" name="mandatory" value="[% iteminformatio.mandatory | html %]" />
>                 [% IF ( iteminformatio.repeatable ) %]
>-                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode); return false;">
>+                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">
>                         <img src="[% interface | html %]/[% theme | html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
>                     </a>
>                 [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>index d82b77070f..965722e5d1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>@@ -326,7 +326,7 @@ $(document).ready(function(){
>               <input type="hidden" name="subfield"       value="[% ite.subfield | html %]" />
>               <input type="hidden" name="mandatory"       value="[% ite.mandatory | html %]" />
>               [% IF ( ite.repeatable ) %]
>-                <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode); return false;">
>+                <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">
>                   <img src="[% interface | html %]/[% theme | html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
>                 </a>
>               [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24649: 98794 | 98795 | 98797 | 98798 | 98829 | 98887 | 98888 | 98949 | 98958 | 98959