Attachment 98964 Details for Bug 23888 – Bug 23888: (follow-up) Wrap English string in translation function

[patch] Bug 23888: (follow-up) Wrap English string in translation function

Bug-23888-follow-up-Wrap-English-string-in-transla.patch (text/plain), 1.84 KB, created by Owen Leonard on 2020-02-14 15:36:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-02-14 15:36:46 UTC

Size: 1.84 KB

patch

obsolete

>From 6d0be24679b42b9888ee196493ae381bc2f72a4d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 14 Feb 2020 15:07:16 +0000
>Subject: [PATCH] Bug 23888: (follow-up) Wrap English string in translation
> function
>
>This patch makes alert added in subscription-add.js translatable using
>the new __() function.
>
>To test, apply the patch and confirm that the alert still works
>correctly when submitting the subscription edit form with an invalid
>vendor id.
>
>Test that the string can be translated (using fr-Fr for example):
>
>1. cd misc/translator && ./translate update fr-FR
>2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
>3. cd misc/translator && ./translate install fr-FR
>
>Switch to the fr-FR translation and confirm the the alert shows your
>translated string.
>---
> koha-tmpl/intranet-tmpl/prog/js/subscription-add.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js b/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>index 79de60df370..ac656eacbdb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>@@ -1,4 +1,4 @@
>-/* global _ irregularity more_than_one_serial subscriptionid tags interface theme mana_enabled MSG_FREQUENCY_LENGTH_ERROR MSG_BIBLIO_NOT_EXIST */
>+/* global __ irregularity more_than_one_serial subscriptionid tags interface theme mana_enabled MSG_FREQUENCY_LENGTH_ERROR MSG_BIBLIO_NOT_EXIST */
> 
> var globalnumpatterndata;
> var globalfreqdata;
>@@ -55,7 +55,7 @@ function Check_page1() {
>     } else {
>         var bookseller_ids = BOOKSELLER_IDS;
>         if ( $.inArray(Number(bookseller_id), bookseller_ids) == -1 ) {
>-            alert ("The vendor does not exist");
>+            alert ( __("The vendor does not exist") );
>             return false;
>         }
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23888: 95253 | 95297 | 98963 | 98964 | 101826 | 101967 | 101968