Bugzilla – Attachment 99113 Details for
Bug 24367
With strict enabled, Search.t is too verbose
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24367: May fix another warning
Bug-24367-May-fix-another-warning.patch (text/plain), 1.08 KB, created by
Jonathan Druart
on 2020-02-17 15:59:45 UTC
(
hide
)
Description:
Bug 24367: May fix another warning
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-17 15:59:45 UTC
Size:
1.08 KB
patch
obsolete
>From ac89ecf103ed40ab7c4a11ffebef92d6aebbd964 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 17 Feb 2020 16:59:15 +0100 >Subject: [PATCH] Bug 24367: May fix another warning > >May fix the following warning: >Use of uninitialized value in concatenation (.) or string at >/kohadevbox/koha/C4/Search.pm line 1818. >--- > C4/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index f79c69a868..d56988e9c2 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1815,7 +1815,7 @@ sub _build_initial_query { > $params->{query_cgi} .= "&q=".uri_escape_utf8($params->{original_operand}) if $params->{original_operand}; > > #e.g. " and kw,wrdl: test" >- $params->{query_desc} .= $operator . $params->{index_plus} . " " . $params->{original_operand}; >+ $params->{query_desc} .= ( $operator . ( $params->{index_plus} // q{} ) . " " . ( $params->{original_operand} // q{} ); > > $params->{previous_operand} = 1 unless $params->{previous_operand}; #If there is no previous operand, mark this as one > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24367
:
96911
|
97096
|
97097
|
97157
|
97158
|
97159
|
97163
| 99113