Bugzilla – Attachment 99126 Details for
Bug 24648
Contextualization of past tense "Created"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24648: Contextualization of past tense 'Created'
Bug-24648-Contextualization-of-past-tense-Created.patch (text/plain), 8.49 KB, created by
Katrin Fischer
on 2020-02-17 19:38:19 UTC
(
hide
)
Description:
Bug 24648: Contextualization of past tense 'Created'
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-02-17 19:38:19 UTC
Size:
8.49 KB
patch
obsolete
>From 0c60ce039c9e5ddbbb327038983a81d59a7df979 Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Wed, 12 Feb 2020 17:29:41 -0500 >Subject: [PATCH] Bug 24648: Contextualization of past tense 'Created' > >In French, everything has one of the binary genders (male or female), >and it affects the past tense verb agreements. > >This patch adds contextualization for the "Created" verb > >The following files have been modified: >booksellers.tt - refers to a basket >basket.tt - refers to a basket >transferorder.tt - refers to a basket >memberentrygen.tt - refers to a patron restriction >suggestion.tt - refers to a suggestion > >To test, apply the patch and visit all those pages in English to make >sure there is no change. >1) Go to Acquisitions >2) Search for vendors >3) On the vendors result pages, check the 'Created by' column heading >of the baskets >4) Click on one of the baskets, check the basket info at the top, >it should say 'Created by:' >5) Click Transfer on one of the orders >6) Search for and choose a vendor >7) In the list of that vendor's basket, it should say 'Created by' >8) Go to a patron's account >9) Add a manual restriction in the Restrictions tab at the bottom >10) In the restriction info, it should say 'Created' >11) Click on the Purchase suggestions tab on the left >12) Add a new suggestion >13) In the Suggestion management section, it should say 'Created by:' >14) Submit the suggestion >15) From the list of suggestions, click on the title >16) In Suggestion management, it should say 'Created by:' > >Next, install a new language (fr-CA used as example) >1) translate create fr-CA >2) open fr-CA-messages.po and add a translation for 'basket created by', >'patron restriction created on' and 'suggestion created by' (it doesn't >have to be real, just write something different for each) >3) translate install fr-CA >4) in the system preferences, enable the french language in >'language' >5) change interface language to french > >Redo the tests above to make sure the word you put in the translation >for the basket is in the places where 'Created by' refers to a basket, that >the translation for the patron restriction is where it should be and that >the translation you put in for the purchase suggestion is in the places where >'Created by' refers to a purchase suggestion > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 5 +++-- > 5 files changed, 9 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index c4d4d178dd..867367307a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -219,7 +219,7 @@ > [% END %] > [% IF deliveryplace %]<li><span class="label">Delivery place:</span> [% Branches.GetName( deliveryplace ) | html %]</li>[% END %] > [% IF billingplace %]<li><span class="label">Billing place:</span> [% Branches.GetName( billingplace ) | html %]</li>[% END %] >- [% IF ( authorisedbyname ) %]<li><span class="label">Created by:</span> [% authorisedbyname | html %]</li>[% END %] >+ [% IF ( authorisedbyname ) %]<li><span class="label">[% tp('basket created by', 'Created by:') | html %]</span> [% authorisedbyname | html %]</li>[% END %] > <li id="managedby"> > <form action="/cgi-bin/koha/acqui/basket.pl" method="post"> > <span class="label">Managed by:</span> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt >index 03f8b93e7e..6271d8d0b1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt >@@ -1,3 +1,4 @@ >+[% PROCESS 'i18n.inc' %] > [% USE raw %] > [% USE Asset %] > [% USE KohaDates %] >@@ -87,7 +88,7 @@ > <th class="title-numeric">Item count</th> > <th class="title-numeric">Bibliographic record count</th> > <th>Items expected</th> >- <th>Created by</th> >+ <th>[% tp('basket created by', 'Created by') | html %]</th> > <th class="title-string">Date</th> > <th>Basket group</th> > <th class="title-string">Closed</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt >index eb94564ccb..7ebb3c3244 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt >@@ -41,7 +41,7 @@ > <thead> > <tr> > <th>Basket (#)</th> >- <th>Created by</th> >+ <th>[% tp('basket created by', 'Created by') | html %]</th> > <th>Date</th> > <th> </th> > </tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index cbb8ae2d0e..30c18d6449 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1,3 +1,4 @@ >+[% PROCESS 'i18n.inc' %] > [% USE raw %] > [% USE Asset %] > [% USE To %] >@@ -1177,7 +1178,7 @@ > <th>Type</th> > <th>Comment</th> > <th>Expiration</th> >- <th>Created</th> >+ <th>[% tp('patron restriction created on', 'Created') | html %]</th> > [% IF CAN_user_borrowers_edit_borrowers && CAN_user_circulate_manage_restrictions %] > <th>Remove?</th> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index adc03227a5..66e6d940c7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1,3 +1,4 @@ >+[% PROCESS 'i18n.inc' %] > [% USE raw %] > [% USE Asset %] > [% USE Branches %] >@@ -167,7 +168,7 @@ > <thead><tr><th> </th><th>Date</th><th>By</th></tr></thead> > <tbody> > <tr> >- <th>Created by:</th> >+ <th>[% tp('purchase suggestion created by', 'Created by:') | html %]</th> > <td>[% suggesteddate | $KohaDates %]</td> > <td> > [% IF ( suggestedby_borrowernumber ) %] >@@ -365,7 +366,7 @@ > <thead><tr><th> </th><th>Date</th><th>By</th></tr></thead> > <tbody> > <tr> >- <th><label for="suggesteddate">Created by:</label> </th> >+ <th><label for="suggesteddate">[% tp('purchase suggestion created by', 'Created by:') | html %]</label> </th> > <td><input type="text" id="suggesteddate" name="suggesteddate" class="datepicker" size="10" maxlength="10" value="[% suggesteddate | $KohaDates %]"/>[% INCLUDE 'date-format.inc' %]</td> > <td><input type="hidden" id="suggestedby" name="suggestedby" value="[% suggestedby | html %]"/>[% IF ( suggestedby_borrowernumber ) %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestedby_borrowernumber | uri %]">[% suggestedby_surname | html %], [% suggestedby_firstname | html %] ([% suggestedby_cardnumber | html %])</a> [% Branches.GetName( suggestedby_branchcode ) | html %] ([% suggestedby_description | html %])[% END %] > </td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24648
:
98782
|
99025
| 99126