Bugzilla – Attachment 99189 Details for
Bug 17221
Orphan comma in shelf browser
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17221: (follow-up) Orphan comma in shelf browser
Bug-17221-follow-up-Orphan-comma-in-shelf-browser.patch (text/plain), 3.00 KB, created by
Jonathan Druart
on 2020-02-18 14:24:51 UTC
(
hide
)
Description:
Bug 17221: (follow-up) Orphan comma in shelf browser
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-02-18 14:24:51 UTC
Size:
3.00 KB
patch
obsolete
>From 39a43cc1f74fd733bbf770bc87a2bc9b1329c914 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 12 Jan 2020 03:55:41 +0000 >Subject: [PATCH] Bug 17221: (follow-up) Orphan comma in shelf browser > >This further improves the display if no location or no >collection has been set. Example output: > >Browsing Centerville shelves, Collection: Non-fiction > >Also changes 'Collection code' to 'collection' and takes >care of additional spaces before the comma. > >To test: >- Make sure your OpacShelfBrowser pref is set to "Show" >- Search for a record with items and callnumbers in your OPAC >- "Browse shelf" >- Navigate back and forth, verify the information showing on > top of the list is correctly formatted >- Try different combinations for the following prefs: > - ShelfBrowserUsesCcode > - ShelfBrowserUsesHomeBranch > - ShelfBrowserUsesLocation >- Verify the display is always nicely formatted > >Note: fixing capitalization here is tricky, as it also >depends on what was displayed before. If you have no >homebranch, you would want "Shelving...", if you have one >we'd like "shelving...". Left as I found it for now. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 6dc1e66220..e2af2e9d55 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -2,11 +2,11 @@ > [% IF OpenOPACShelfBrowser %] > <div id="shelfbrowser"> > <h5 style="text-align: center;"> >- [% IF ( starting_homebranch ) %]Browsing [% starting_homebranch | html %] Shelves[% END %] >- [% IF ( starting_homebranch && ( starting_location || starting_ccode ) ) %], [% END %] >- [% IF ( starting_location ) %]Shelving location: [% starting_location | html %][% END %] >- [% IF ( ( starting_homebranch || starting_location ) && starting_ccode ) %], [% END %] >- [% IF ( starting_ccode ) %]Collection code: [% starting_ccode | html %][% END %] >+ [%- IF ( starting_homebranch ) %]Browsing [% starting_homebranch | html %] shelves[% END -%] >+ [%- IF ( starting_homebranch && starting_location ) %], [% END %] >+ [%- IF ( starting_location ) %]Shelving location: [%- starting_location | html -%][% END -%] >+ [%- IF ( starting_homebranch && starting_ccode ) %], [% END %] >+ [%- IF ( starting_ccode ) %]Collection: [%- starting_ccode | html -%][% END -%] > <a style="font-size: 75%;" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]" class="close_shelf" >Close shelf browser</a> > </h5> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17221
:
54997
|
54998
|
97267
|
97268
|
98830
|
98831
|
99188
| 99189