Bugzilla – Attachment 99218 Details for
Bug 22245
MARC modification templates does not allow move or copy control fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22245: Allow copy/move from and to control fields
Bug-22245-Allow-copymove-from-and-to-control-field.patch (text/plain), 1.69 KB, created by
Martin Renvoize (ashimema)
on 2020-02-18 19:11:52 UTC
(
hide
)
Description:
Bug 22245: Allow copy/move from and to control fields
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-02-18 19:11:52 UTC
Size:
1.69 KB
patch
obsolete
>From c3e6a5c9db0eb791be7a5e7b59d85c706d005d8b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 16 Feb 2019 11:46:08 -0300 >Subject: [PATCH] Bug 22245: Allow copy/move from and to control fields > >The JS conditions were wrong, we want to allow copy and move between >control fields. > >Test plan: >Create a new MARC modification template action using control fields. >Confirm that you are allowed to copy/move a control field to another one > >Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> >Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/js/marc_modification_templates.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js b/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js >index eb1bf39718..bde38033df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js >@@ -25,8 +25,8 @@ $(document).ready(function() { > alert( MSG_MMT_CONTROL_FIELD_EMPTY ); > return false; > } >- if ( ( $("#from_field").val() < 10 && $("#to_subfield").val().length === 0 ) || >- ( $("#to_field").val() < 10 && $("#from_subfield").val().length === 0 ) ) { >+ if ( ( $("#from_field").val() < 10 && $("#to_field").val() >= 10 ) || >+ ( $("#to_field").val() < 10 && $("#from_field").val() >= 10 ) ) { > alert( MSG_MMT_CONTROL_FIELD ); > return false; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22245
:
85209
|
97847
|
99044
| 99218