Bugzilla – Attachment 99219 Details for
Bug 24051
batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl
Bug-24051-Remove-search-condition--is-deprecated-w.patch (text/plain), 1.40 KB, created by
Martin Renvoize (ashimema)
on 2020-02-18 19:18:35 UTC
(
hide
)
Description:
Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-02-18 19:18:35 UTC
Size:
1.40 KB
patch
obsolete
>From e9d059498757572cad0accf1602fb26a58b3e145 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 18 Nov 2019 11:29:46 +0100 >Subject: [PATCH] Bug 24051: Remove "search( %condition ) is deprecated" > warning from batchMod.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: >Go to Home ⺠Tools ⺠Batch item modification >Insert barcodes and continue >=> Without this patch you will get warning in the log >=> With this patch applied you warning does no longer appear >Confirm that the number of holds is correct > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > tools/batchMod.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 3da1efb80c..f9fb0a5f7c 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -632,7 +632,7 @@ sub BuildItemsData{ > $this_row{isbn} = $biblio->biblioitem->isbn; > $this_row{biblionumber} = $biblio->biblionumber; > $this_row{holds} = $biblio->holds->count; >- $this_row{item_holds} = Koha::Holds->search( itemnumber => $itemnumber )->count; >+ $this_row{item_holds} = Koha::Holds->search( { itemnumber => $itemnumber } )->count; > > if (%this_row) { > push(@big_array, \%this_row); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24051
:
95486
|
98999
| 99219