Attachment 99221 Details for Bug 24494 – Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules

[patch] Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules

Bug-24494-tests-00-valid-xmlt-shouldnt-check-nodem.patch (text/plain), 1.29 KB, created by Martin Renvoize (ashimema) on 2020-02-18 19:46:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-18 19:46:53 UTC

Size: 1.29 KB

patch

obsolete

>From ed4f09ff08eb9f70f217d42cc9cf5de4e58c6692 Mon Sep 17 00:00:00 2001
>From: Victor Grousset/tuxayo <victor@tuxayo.net>
>Date: Thu, 23 Jan 2020 15:55:18 +0100
>Subject: [PATCH] Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules
>
>== Test plan ==
>- work with SCSS (just recompile it if you never did)
>  - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS
>- now you have a node_modules directory
>- prove -r t/00-valid-xml.t
>- it should fail on files in node_modules
>- apply this patch
>- prove -r t/00-valid-xml.t
>- it should work
>- sabotage a legitimate XML file, like etc/SIPconfig.xml
>- prove -r t/00-valid-xml.t
>- it should fail, good the test is still useful
>- undo the sabotage
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/00-valid-xml.t | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/t/00-valid-xml.t b/t/00-valid-xml.t
>index 2c5393abd7..d19b4e68d1 100644
>--- a/t/00-valid-xml.t
>+++ b/t/00-valid-xml.t
>@@ -30,6 +30,7 @@ find({
>     no_chdir => 1,
>     wanted => sub {
>         my $file = $_;
>+        return if $file =~ /node_modules/i;
>         return unless $file =~ /(\.xml|\.xsl|\.xslt|\.xsd)$/i;
>         my $dom;
>         eval { $dom = $parser->parse_file($file); };
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24494: 97825 | 98861 | 98862 | 99221 | 99222