Attachment 99356 Details for Bug 17510 – Bug 17510: update MMT-related unit tests

[patch] Bug 17510: update MMT-related unit tests

Bug-17510-update-MMT-related-unit-tests.patch (text/plain), 8.15 KB, created by Martin Renvoize (ashimema) on 2020-02-21 08:29:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-21 08:29:59 UTC

Size: 8.15 KB

patch

obsolete

>From e489fa2a7d9332aace63014c38a03248ec926698 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <arouss1980@gmail.com>
>Date: Fri, 14 Feb 2020 20:07:50 +0000
>Subject: [PATCH] Bug 17510: update MMT-related unit tests
>
>The unit tests related to MARC modification templates need to be
>updated with extra tests specific to actions involving subfield 0.
>
>Test plan:
>0) Apply the patch.
>1) Run the updated unit tests, they should pass without any errors:
>   $ prove t/SimpleMARC.t
>   $ prove t/db_dependent/MarcModificationTemplates.t
>
>Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/SimpleMARC.t                             |  40 +++++-
> t/db_dependent/MarcModificationTemplates.t | 135 ++++++++++++++++++++-
> 2 files changed, 171 insertions(+), 4 deletions(-)
>
>diff --git a/t/SimpleMARC.t b/t/SimpleMARC.t
>index d32ac88bf5..4fd8933b29 100644
>--- a/t/SimpleMARC.t
>+++ b/t/SimpleMARC.t
>@@ -74,13 +74,17 @@ subtest 'field_exists' => sub {
> subtest 'read_field' => sub {
>     plan tests              => 2;
>     subtest 'read subfield' => sub {
>-        plan tests => 5;
>+        plan tests => 6;
>         my $record = new_record;
>         $record->append_fields(
>             MARC::Field->new(
>                 650, ' ', '0',
>                 a => 'Computer algorithms.',
>                 9 => '463',
>+            ),
>+            MARC::Field->new(
>+                600, ' ', '0',
>+                0 => '123456',
>             )
>         );
> 
>@@ -130,6 +134,20 @@ subtest 'read_field' => sub {
>             [],
>             'There is no 3 650$a'
>         );
>+        is_deeply(
>+            [
>+                read_field(
>+                    {
>+                        record        => $record,
>+                        field         => '600',
>+                        subfield      => '0',
>+                        field_numbers => [1]
>+                    }
>+                )
>+            ],
>+            ['123456'],
>+            'first 600$0'
>+        );
>     };
>     subtest 'read field' => sub {
>         plan tests => 4;
>@@ -191,7 +209,7 @@ subtest 'read_field' => sub {
> subtest 'update_field' => sub {
>     plan tests                => 1;
>     subtest 'update subfield' => sub {
>-        plan tests => 5;
>+        plan tests => 6;
>         my $record = new_record;
> 
>         update_field(
>@@ -250,6 +268,7 @@ subtest 'update_field' => sub {
>                 952, ' ', ' ',
>                 p => '3010023917',
>                 y => 'BK',
>+                0 => '123456',
>             ),
>         );
>         update_field(
>@@ -283,6 +302,23 @@ subtest 'update_field' => sub {
>             [ '3010023917', '3010023918' ],
>             'update all subfields 952$p with the different values'
>         );
>+
>+        update_field(
>+            {
>+                record   => $record,
>+                field    => '952',
>+                subfield => '0',
>+                values   => [ '654321' ]
>+            }
>+        );
>+        my @fields_9520 =
>+          read_field( { record => $record, field => '952', subfield => '0' } );
>+        is_deeply(
>+            \@fields_9520,
>+            [ '654321', '654321' ],
>+            'update all subfields 952$0 with the same value'
>+        );
>+
>     };
> };
> 
>diff --git a/t/db_dependent/MarcModificationTemplates.t b/t/db_dependent/MarcModificationTemplates.t
>index f9628d7f2b..2d646190f6 100644
>--- a/t/db_dependent/MarcModificationTemplates.t
>+++ b/t/db_dependent/MarcModificationTemplates.t
>@@ -1,6 +1,6 @@
> use Modern::Perl;
> 
>-use Test::More tests => 115;
>+use Test::More tests => 125;
> 
> use Koha::Database;
> use Koha::SimpleMARC;
>@@ -55,7 +55,7 @@ is( AddModificationTemplateAction(
> # Getter
> 
> my @actions = GetModificationTemplateActions( $template_id );
>-is( @actions, 4, "4 actions are insered");
>+is( @actions, 4, "4 actions are inserted");
> 
> for my $action ( @actions ) {
>     isnt( GetModificationTemplateAction( $action->{mmta_id} ), undef, "action with id $action->{mmta_id} exists" );
>@@ -546,3 +546,134 @@ sub expected_record_2 {
>     $record->append_fields(@fields);
>     return $record;
> }
>+
>+# Tests related to use of subfield 0 ($0)
>+
>+sub new_record_0 {
>+    my $record = MARC::Record->new;
>+    $record->leader('03174nam a2200445 a 4500');
>+    my @fields = (
>+        MARC::Field->new(
>+            100, '1', ' ',
>+            0 => '12345',
>+            a => 'Knuth, Donald Ervin',
>+            d => '1938',
>+        ),
>+        MARC::Field->new(
>+            245, '1', '4',
>+            0 => '12345',
>+            a => 'The art of computer programming',
>+            c => 'Donald E. Knuth.',
>+        ),
>+        MARC::Field->new(
>+            650, ' ', '0',
>+            0 => '42',
>+            a => 'Computer programming.',
>+            9 => '462',
>+        ),
>+    );
>+    $record->append_fields(@fields);
>+    return $record;
>+}
>+
>+sub expected_record_0 {
>+    my $record = MARC::Record->new;
>+    $record->leader('03174nam a2200445 a 4500');
>+    my @fields = (
>+        MARC::Field->new(
>+            245, '1', '4',
>+            0 => '12345',
>+            a => 'The art of computer programming',
>+            c => 'Donald E. Knuth.',
>+        ),
>+        MARC::Field->new(
>+            650, ' ', '0',
>+            0 => '42',
>+            a => 'Computer programming.',
>+            9 => '462',
>+        ),
>+        MARC::Field->new(
>+            600, ' ', ' ',
>+            0 => 'TestUpdated',
>+        ),
>+        MARC::Field->new(
>+            100, ' ', ' ',
>+            0 => 'TestUpdated',
>+        ),
>+        MARC::Field->new(
>+            700, '1', '4',
>+            0 => '12345',
>+            a => 'The art of computer programming',
>+            c => 'Donald E. Knuth.',
>+        ),
>+    );
>+    $record->append_fields(@fields);
>+    return $record;
>+}
>+
>+$record = new_record_0();
>+is( ModifyRecordWithTemplate( $template_id, $record ), undef, "The ModifyRecordWithTemplate returns undef" );
>+
>+$template_id = AddModificationTemplate("template_test_subfield_0");
>+like( $template_id, qr|^\d+$|, "new template returns an id" );
>+
>+# Delete subfield 100$0
>+is( AddModificationTemplateAction(
>+    $template_id, 'delete_field', 0,
>+    '100', '0', '', '', '',
>+    '', '', '',
>+    '', '', '', '', '', '',
>+    'Action 1: Delete subfield 100$0'
>+), 1, 'Action 1: Delete subfield 100$0');
>+
>+# Add new subfield 100$0 with value "Test"
>+is( AddModificationTemplateAction(
>+    $template_id, 'add_field', 0,
>+    '100', '0', 'Test', '', '',
>+    '', '', '',
>+    '', '', '', '', '', '',
>+    'Action 2: Add new subfield 100$0 with value "Test"'
>+), 1, 'Action 2: Add new subfield 100$0');
>+
>+# Update existing or add new subfield 100$0 with value "TestUpdated"
>+is( AddModificationTemplateAction(
>+    $template_id, 'update_field', 0,
>+    '100', '0', 'TestUpdated', '', '',
>+    '', '', '',
>+    '', '', '', '', '', '',
>+    'Action 3: Update existing or add new subfield 100$0 with value "TestUpdated"'
>+), 1, 'Action 3: Update existing or add new subfield 100$0 with value "TestUpdated"');
>+
>+# Move subfield 100$0 to 600$0
>+is( AddModificationTemplateAction(
>+    $template_id, 'move_field', 0,
>+    '100', '0', '', '600', '0',
>+    '', '', '',
>+    '', '', '', '', '', '',
>+    'Action 4: Move subfield 100$0 to 600$0'
>+), 1, 'Action 4: Move subfield 100$0 to 600$0');
>+
>+# Copy subfield 600$0 to 100$0
>+is( AddModificationTemplateAction(
>+    $template_id, 'copy_field', 0,
>+    '600', '0', '', '100', '0',
>+    '', '', '',
>+    '', '', '', '', '', '',
>+    'Action 5: Copy subfield 600$0 to 100$0'
>+), 1, 'Action 5: Copy subfield 600$0 to 100$0');
>+
>+# Copy and replace subfield 245$0 to 700$0
>+is( AddModificationTemplateAction(
>+    $template_id, 'copy_and_replace_field', 0,
>+    '245', '0', '', '700', '0',
>+    '', '', '',
>+    '', '', '', '', '', '',
>+    'Action 6: Copy and replace subfield 245$0 to 700$0'
>+), 1, 'Action 6: Copy and replace subfield 245$0 to 700$0');
>+
>+my @actions_0 = GetModificationTemplateActions( $template_id );
>+is( @actions_0, 6, "6 actions are inserted");
>+
>+ModifyRecordWithTemplate( $template_id, $record );
>+my $expected_record_0 = expected_record_0();
>+is_deeply( $record, $expected_record_0, '100$0 has been deleted, added back, updated, moved to 600$0, and copied back to 100$0; finally, 245$0 has been copied and replaced to 700$0' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 17510: 99028 | 99029 | 99031 | 99034 | 99035 | 99050 | 99051 | 99052 | 99356 | 99357