Attachment 99386 Details for Bug 24705 – Bug 24705: Holds placed via SIP will be given first priority

[patch] Bug 24705: Holds placed via SIP will be given first priority

Bug-24705-Holds-placed-via-SIP-will-be-given-first.patch (text/plain), 1.16 KB, created by Kyle M Hall (khall) on 2020-02-21 14:45:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-02-21 14:45:03 UTC

Size: 1.16 KB

patch

obsolete

>From 4fa803e8e40c00be6c3956f2a826a2bc17479efc Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 21 Feb 2020 09:41:27 -0500
>Subject: [PATCH] Bug 24705: Holds placed via SIP will be given first priority
>
>The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1.
>
>Test Plan:
>1) Place a hold via SIP for a record with existing holds
>2) Note the new hold is top priority
>3) Apply this patch
>4) Restart SIP
>5) Repeat step 1
>6) New hold should be last priority
>---
> C4/SIP/ILS/Transaction/Hold.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/C4/SIP/ILS/Transaction/Hold.pm b/C4/SIP/ILS/Transaction/Hold.pm
>index ecf8416640..d51ebde199 100644
>--- a/C4/SIP/ILS/Transaction/Hold.pm
>+++ b/C4/SIP/ILS/Transaction/Hold.pm
>@@ -66,8 +66,10 @@ sub do_hold {
>         return $self;
>     }
> 
>+    my $priority = C4::Reserves::CalculatePriority($item->biblionumber);
>     AddReserve(
>         {
>+            priority       => $priority,
>             branch         => $branch,
>             borrowernumber => $patron->borrowernumber,
>             biblionumber   => $item->biblionumber
>-- 
>2.21.1 (Apple Git-122.3)

Actions: View | Diff | Splinter Review

Attachments on bug 24705: 99386 | 99427 | 99483 | 99484 | 102520