Attachment 99402 Details for Bug 24584 – Bug 24584: Rewrite optional/csv_profiles to YAML

[patch] Bug 24584: Rewrite optional/csv_profiles to YAML

Bug-24584-Rewrite-optionalcsvprofiles-to-YAML.patch (text/plain), 3.72 KB, created by Martin Renvoize (ashimema) on 2020-02-21 16:39:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-21 16:39:23 UTC

Size: 3.72 KB

patch

obsolete

>From f9b84408b8a84624b548af2332edbb828c81de51 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Tue, 4 Feb 2020 20:56:30 -0300
>Subject: [PATCH] Bug 24584: Rewrite optional/csv_profiles to YAML
>
>YAML version of optional csv_profiles.
>
>To test:
>1) Do a clean install with optional data,
>   dump table export_format, reserve.
>
>2) Apply this patch and it's dependencies
>
>3) Do a clean install, dump again and compare
>   No major differences expected
>
>4) Try translation
>  a) Go to misc/translator
>  b) create files for a new language
>     ./translate create xx-YY
>  c) Check new file po/xx-YY-instaler.po
>     Verify strings from this file.
>  d) Install new language
>     ./translate install xx-YY
>  e) Try clean install with new files
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/en/optional/csv_profiles.sql   |  2 --
> .../data/mysql/en/optional/csv_profiles.txt   |  3 --
> .../data/mysql/en/optional/csv_profiles.yml   | 36 +++++++++++++++++++
> 3 files changed, 36 insertions(+), 5 deletions(-)
> delete mode 100644 installer/data/mysql/en/optional/csv_profiles.sql
> delete mode 100644 installer/data/mysql/en/optional/csv_profiles.txt
> create mode 100644 installer/data/mysql/en/optional/csv_profiles.yml
>
>diff --git a/installer/data/mysql/en/optional/csv_profiles.sql b/installer/data/mysql/en/optional/csv_profiles.sql
>deleted file mode 100644
>index 86c2394d76..0000000000
>--- a/installer/data/mysql/en/optional/csv_profiles.sql
>+++ /dev/null
>@@ -1,2 +0,0 @@
>-INSERT IGNORE INTO export_format( profile, description, content, csv_separator, type, used_for ) 
>-VALUES ( "issues to claim", "default CSV export for serial issue claims", "SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate", ",", "sql", "late_issues" );
>diff --git a/installer/data/mysql/en/optional/csv_profiles.txt b/installer/data/mysql/en/optional/csv_profiles.txt
>deleted file mode 100644
>index 9dcff5d0ed..0000000000
>--- a/installer/data/mysql/en/optional/csv_profiles.txt
>+++ /dev/null
>@@ -1,3 +0,0 @@
>-CSV profiles
>-
>-Default CSV export profiles; including one for exporting serial claims.
>diff --git a/installer/data/mysql/en/optional/csv_profiles.yml b/installer/data/mysql/en/optional/csv_profiles.yml
>new file mode 100644
>index 0000000000..5245c18bc3
>--- /dev/null
>+++ b/installer/data/mysql/en/optional/csv_profiles.yml
>@@ -0,0 +1,36 @@
>+---
>+#
>+#  Copyright 2020 Koha Development Team
>+#
>+#  This file is part of Koha.
>+#
>+#  Koha is free software; you can redistribute it and/or modify it under the
>+#  terms of the GNU General Public License as published by the Free Software
>+#  Foundation; either version 2 of the License, or (at your option) any later
>+#  version.
>+#
>+#  Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+#  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+#  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+#  You should have received a copy of the GNU General Public License along
>+#  with Koha; if not, write to the Free Software Foundation, Inc.,
>+#  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+#
>+
>+description:
>+  - "CSV profiles"
>+  - ""
>+  - "Default CSV export profiles; including one for exporting serial claims."
>+
>+tables:
>+  - export_format:
>+      translatable: [ profile, description ]
>+      multiline: []
>+      rows:
>+        - profile: "issues to claim"
>+          description: "default CSV export for serial issue claims"
>+          content: "SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate"
>+          csv_separator: ","
>+          type: sql
>+          used_for: late_issues
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24584: 98464 | 98465 | 98466 | 98467 | 98468 | 98469 | 98470 | 98471 | 98472 | 98473 | 98474 | 98475 | 98476 | 98477 | 99402 | 99403 | 99404 | 99405 | 99406 | 99407 | 99408 | 99409 | 99410 | 99411 | 99412 | 99413 | 99414 | 99415 | 100352 | 100353 | 100354 | 100355 | 100356 | 100357 | 100358 | 100359 | 100360 | 100361 | 100362 | 100363 | 100364 | 100365