Attachment 99405 Details for Bug 24584 – Bug 24584: Rewrite optional/parameters to YAML

[patch] Bug 24584: Rewrite optional/parameters to YAML

Bug-24584-Rewrite-optionalparameters-to-YAML.patch (text/plain), 3.11 KB, created by Martin Renvoize (ashimema) on 2020-02-21 16:39:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-21 16:39:33 UTC

Size: 3.11 KB

patch

obsolete

>From 438526b8160d05160afd6927b28498f9e9b277d5 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Tue, 4 Feb 2020 21:01:27 -0300
>Subject: [PATCH] Bug 24584: Rewrite optional/parameters to YAML
>
>YAML version of optional parameters
>
>To test:
>1) Same test plan of first patch, only check table
>   currency
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/en/optional/parameters.sql     |  5 --
> .../data/mysql/en/optional/parameters.txt     |  1 -
> .../data/mysql/en/optional/parameters.yml     | 47 +++++++++++++++++++
> 3 files changed, 47 insertions(+), 6 deletions(-)
> delete mode 100644 installer/data/mysql/en/optional/parameters.sql
> delete mode 100644 installer/data/mysql/en/optional/parameters.txt
> create mode 100644 installer/data/mysql/en/optional/parameters.yml
>
>diff --git a/installer/data/mysql/en/optional/parameters.sql b/installer/data/mysql/en/optional/parameters.sql
>deleted file mode 100644
>index 16e86420a3..0000000000
>--- a/installer/data/mysql/en/optional/parameters.sql
>+++ /dev/null
>@@ -1,5 +0,0 @@
>-INSERT INTO `currency` (currency, rate, symbol, active) VALUES
>-('USD', 1.0, '$', '1'),
>-('GBP', 1.9929, 'Â£', '0'),
>-('CAD', 1.02207, '$', '0'),
>-('EUR', .874003, 'â¬', '0');
>diff --git a/installer/data/mysql/en/optional/parameters.txt b/installer/data/mysql/en/optional/parameters.txt
>deleted file mode 100644
>index a778b1f20c..0000000000
>--- a/installer/data/mysql/en/optional/parameters.txt
>+++ /dev/null
>@@ -1 +0,0 @@
>-Some basic currencies with USA dollar as default for ACQ module
>diff --git a/installer/data/mysql/en/optional/parameters.yml b/installer/data/mysql/en/optional/parameters.yml
>new file mode 100644
>index 0000000000..3df32146d9
>--- /dev/null
>+++ b/installer/data/mysql/en/optional/parameters.yml
>@@ -0,0 +1,47 @@
>+---
>+#
>+#  Copyright 2020 Koha Development Team
>+#
>+#  This file is part of Koha.
>+#
>+#  Koha is free software; you can redistribute it and/or modify it under the
>+#  terms of the GNU General Public License as published by the Free Software
>+#  Foundation; either version 2 of the License, or (at your option) any later
>+#  version.
>+#
>+#  Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+#  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+#  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+#  You should have received a copy of the GNU General Public License along
>+#  with Koha; if not, write to the Free Software Foundation, Inc.,
>+#  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+#
>+
>+description:
>+  - "Some basic currencies with USA dollar as default for ACQ module"
>+
>+tables:
>+  - currency:
>+      translatable: [ ]
>+      multiline: []
>+      rows:
>+        - currency: "USD"
>+          rate: 1.0
>+          symbol: "$"
>+          active: 1
>+
>+        - currency: "GBP"
>+          rate: 1.9929
>+          symbol: "Â£"
>+          active: 0
>+
>+        - currency: "CAD"
>+          rate: 1.02207
>+          symbol: "$"
>+          active: 0
>+
>+        - currency: "EUR"
>+          rate: .874003
>+          symbol: "â¬"
>+          active: 0
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24584: 98464 | 98465 | 98466 | 98467 | 98468 | 98469 | 98470 | 98471 | 98472 | 98473 | 98474 | 98475 | 98476 | 98477 | 99402 | 99403 | 99404 | 99405 | 99406 | 99407 | 99408 | 99409 | 99410 | 99411 | 99412 | 99413 | 99414 | 99415 | 100352 | 100353 | 100354 | 100355 | 100356 | 100357 | 100358 | 100359 | 100360 | 100361 | 100362 | 100363 | 100364 | 100365