Bugzilla – Attachment 99472 Details for
Bug 24710
patron-title.inc should have seperate span classes for firstname, othername, surname
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24710: Add span classes to patron first/other/sur names
Bug-24710-Add-span-classes-to-patron-firstothersur.patch (text/plain), 2.56 KB, created by
Lucas Gass (lukeg)
on 2020-02-23 19:01:02 UTC
(
hide
)
Description:
Bug 24710: Add span classes to patron first/other/sur names
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2020-02-23 19:01:02 UTC
Size:
2.56 KB
patch
obsolete
>From 49d90ce3edb649dc3059a1b466e0cb081901d380 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 21 Feb 2020 19:17:51 +0000 >Subject: [PATCH] Bug 24710: Add span classes to patron first/other/sur names > >This patch adds some <span> elements with classes to patron-title.inc >TEST PLAN: >1. Have a patron with a title, firstname, surname, and othername >2. Apply patch >3. There should be no visible changes but if you inscept each element you should see seperate elements with clases. >4. Add each of these to IntranetUserCSS to make sure it hides that element (this effects patroninfo section AND breadcrumbs) > .firstname {display: none;} > .othernames {display:none}; > .surname{display:none;} > .title{display:none;} >5. Sign-off >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index d5dcd7d0f0..5473cc1df8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -58,11 +58,11 @@ > [%- END -%] > [%- IF display_patron_name -%] > [%- IF data.category_type == 'I' -%] >- [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] >+ <span class="surname">[%- data.surname | html %]</span> [% IF data.othernames %] <span class="othernames">([% data.othernames | html %])</span>[% END -%] > [%- ELSIF invert_name -%] >- [% data.title | $raw %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%] >+ <span class="title">[% data.title | $raw %]</span><span class="surname">[%- data.surname | html %]</span>, <span class="firstname">[% data.firstname | html %]</span> [% IF data.othernames %] <span class="othernames">([% data.othernames | html %])</span> [% END -%] > [%- ELSE -%] >- [% data.title | $raw %][%- data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END %] [% data.surname | html -%] >+ <span class="title">[% data.title | $raw %]</span><span class="firstname">[%- data.firstname | html %]</span> [% IF data.othernames %]<span class="othernames">([% data.othernames | html %])</span> [% END %]<span class="surname"> [% data.surname | html -%]</span> > [%- END -%] > [%- IF display_cardnumber AND data.cardnumber %] ([% data.cardnumber | html %])[% END -%] > [%- ELSIF display_cardnumber -%] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24710
:
99428
|
99451
|
99472
|
99683
|
100078
|
101557