Attachment 99475 Details for Bug 24693 – Bug 24693: Move GD from recommends to requires in cpanfile

[patch] Bug 24693: Move GD from recommends to requires in cpanfile

Bug-24693-Move-GD-from-recommends-to-requires-in-c.patch (text/plain), 1.38 KB, created by Bernardo Gonzalez Kriegel on 2020-02-23 23:00:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2020-02-23 23:00:44 UTC

Size: 1.38 KB

patch

obsolete

>From 72ed2f562d632018ff960f5bb65d5b9bbe133bb5 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Thu, 20 Feb 2020 08:29:37 +0100
>Subject: [PATCH] Bug 24693: Move GD from recommends to requires in cpanfile
>
>Without it, catalogue/detail.pl dies (and probably other scripts too)
>
>Test plan:
>1. Uninstall GD, reload starman
>2. Go to catalogue/detail.pl. Confirm that it dies
>3. Reinstall GD, reload starman
>4. Go to catalogue/detail.pl. Confirm that it work normally
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>catalogue/detail.pl dies without GD.
>Seems correct switch to require
>No errors
>---
> cpanfile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/cpanfile b/cpanfile
>index 4837e7b2b3..b123f578ce 100644
>--- a/cpanfile
>+++ b/cpanfile
>@@ -41,6 +41,7 @@ requires 'Email::Valid', '0.190';
> requires 'Exception::Class', '1.38';
> requires 'File::Slurp', '9999.13';
> requires 'Font::TTF', '0.45';
>+requires 'GD', '2.39';
> requires 'GD::Barcode::UPCE', '1.1';
> requires 'Getopt::Long', '2.35';
> requires 'Getopt::Std', '1.05';
>@@ -138,7 +139,6 @@ recommends 'Devel::Cover', '0.89';
> recommends 'File::Copy', '2.08';
> recommends 'File::Path', '2.07';
> recommends 'File::Temp', '0.22';
>-recommends 'GD', '2.39';
> recommends 'Graphics::Magick', 'v1.3.5';
> recommends 'Gravatar::URL', '1.03';
> recommends 'HTTPD::Bench::ApacheBench', '0.73';
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 24693: 99299 | 99475 | 99510