Attachment 9951 Details for Bug 8196 – Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron

[patch] Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron

Bug-8196-FIX-for-Bug-5742-All-extended-attributes-.patch (text/plain), 1.57 KB, created by Dobrica Pavlinusic on 2012-06-06 13:32:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dobrica Pavlinusic

Created: 2012-06-06 13:32:57 UTC

Size: 1.57 KB

patch

obsolete

>From b6f6bdfd8fd492532cffc953e62c388a9aa5d905 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 6 Jun 2012 12:56:56 +0200
>Subject: [PATCH] Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron
>
>Test scenario:
>
>1. make sure that you have ExtendedPatronAttributes enabled
>2. open /cgi-bin/koha/members/memberentry.pl?op=add;categorycode=S0
>   (you might need to modify categorycode according to your local config)
>3. verify that you get all extended patron attributes in form
>
>Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
>---
> C4/Members/Attributes.pm |    5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm
>index b373c94..cde25d1 100644
>--- a/C4/Members/Attributes.pm
>+++ b/C4/Members/Attributes.pm
>@@ -77,12 +77,11 @@ sub GetBorrowerAttributes {
>                  FROM borrower_attributes
>                  JOIN borrower_attribute_types USING (code)
>                  LEFT JOIN authorised_values ON (category = authorised_value_category AND attribute = authorised_value)
>-                 WHERE 1";
>-    $query .= "\nAND borrowernumber = ?" if $borrowernumber;
>+                 WHERE borrowernumber = ?";
>     $query .= "\nAND opac_display = 1" if $opac_only;
>     $query .= "\nORDER BY code, attribute";
>     my $sth = $dbh->prepare_cached($query);
>-    $sth->execute($borrowernumber ? $borrowernumber : ());
>+    $sth->execute($borrowernumber);
>     my @results = ();
>     while (my $row = $sth->fetchrow_hashref()) {
>         push @results, {
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8196: 9948 | 9951