Bugzilla – Attachment 99511 Details for
Bug 23411
SMS messages sent as print should not fall back to 'email'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23411 - SMS messages should not fall back to 'email'
Bug-23411---SMS-messages-should-not-fall-back-to-e.patch (text/plain), 2.02 KB, created by
Martin Renvoize (ashimema)
on 2020-02-24 12:49:09 UTC
(
hide
)
Description:
Bug 23411 - SMS messages should not fall back to 'email'
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-02-24 12:49:09 UTC
Size:
2.02 KB
patch
obsolete
>From 60c43fe7d62ccb8e34b22ccd62fe31b80a79cdfe Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 1 Aug 2019 14:57:29 +0000 >Subject: [PATCH] Bug 23411 - SMS messages should not fall back to 'email' > >To test: > 1 - Have a patron wiht an sms number, but no email > 2 - Enable sms by setting SMSDriver syspref to Email > 3 - Set Notice triggers to send an overdue via sms and email > 4 - Ensure the selected notice is defined only for 'email' > 5 - Checkout an overdue to the patron above > You can set a specify a due date in the past > 6 - perl misc/cronjobs/overdue_notices.pl -t > 7 - Check the patron notices tab, they have a print notice and an SMS notice pending > 8 - The SMS notice used the 'email' template > 9 - Apply patch >10 - sudo koha-mysql kohadev >11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above}; >12 - Run the cron again >13 - Patron should have a print notice queued, no sms >14 - Define an SMS notice >15 - delete the message queue >16 - Run again >17 - The patron should have a print and an SMS > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > misc/cronjobs/overdue_notices.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 75fd593c77..a4348fed24 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -699,8 +699,8 @@ END_SQL > 'count' => $itemcount, > }, > # If there is no template defined for the requested letter >- # Fallback on email >- message_transport_type => $letter_exists ? $effective_mtt : 'email', >+ # Fallback on the original type >+ message_transport_type => $letter_exists ? $effective_mtt : $mtt, > } > ); > unless ($letter) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23411
:
91907
|
99511
|
101091
|
101092