Bugzilla – Attachment 99688 Details for
Bug 24052
Koha::XSLT housekeeping for bug 23290 (follow-up)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24052: Catch warning between test 6 and 7
Bug-24052-Catch-warning-between-test-6-and-7.patch (text/plain), 1.52 KB, created by
Marcel de Rooy
on 2020-02-27 08:37:58 UTC
(
hide
)
Description:
Bug 24052: Catch warning between test 6 and 7
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-02-27 08:37:58 UTC
Size:
1.52 KB
patch
obsolete
>From 02ff929cfb85da1656018fa48213a7ff650051dd Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 25 Feb 2020 15:09:53 +0000 >Subject: [PATCH] Bug 24052: Catch warning between test 6 and 7 >Content-Type: text/plain; charset=utf-8 > >Resolve: >ok 6 - Engine returns error on undefined text >XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214. >ok 7 - Engine returns error on empty string > >Test plan: >Run perl Base.t and verify that this warning is no longer printed. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/XSLT/Base.t | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/XSLT/Base.t b/t/db_dependent/Koha/XSLT/Base.t >index 94b3ddfa79..d948be8ebb 100644 >--- a/t/db_dependent/Koha/XSLT/Base.t >+++ b/t/db_dependent/Koha/XSLT/Base.t >@@ -22,7 +22,7 @@ use Modern::Perl; > use FindBin; > use File::Temp qw/tempfile/; > use File::Slurp; >-use Test::More tests => 32; >+use Test::More tests => 33; > use Test::Warn; > > use Koha::XSLT::Base; >@@ -49,7 +49,9 @@ $output = $engine->transform( undef, $xsltfile_1 ); > is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_7, 'Engine returns error on undefined text' ); > > # Empty string tests >-$output = $engine->transform( '', $xsltfile_1 ); >+warning_like {$output = $engine->transform( '', $xsltfile_1 ) } >+ qr/XSLT::Base: Empty String/, >+ 'Empty string warning detected'; > is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_5, 'Engine returns error on empty string' ); > > # Non-XML tests >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24052
:
99686
|
99687
|
99688
|
99689
|
100371
|
100372
|
100373
|
100374
|
100406
|
100407
|
100408
|
100409
|
100453
|
100454
|
100455
|
100456
|
101118
|
101119
|
101120
|
101121