Attachment 99716 Details for Bug 24747 – BUG 24747: Corrects on-screen instructions in branch transfer limits

[patch] BUG 24747: Corrects on-screen instructions in branch transfer limits

BUG-24747-Corrects-on-screen-instructions-in-branc.patch (text/plain), 2.75 KB, created by ByWater Sandboxes on 2020-02-27 21:02:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2020-02-27 21:02:31 UTC

Size: 2.75 KB

patch

obsolete

>From 9e5859bf82d0b1b83454b00b4bf3ae8c993be4be Mon Sep 17 00:00:00 2001
>From: Andrew Fuerste-Henry <andrew@Andrews-MacBook-Pro.local>
>Date: Thu, 27 Feb 2020 14:09:02 -0600
>Subject: [PATCH] BUG 24747: Corrects on-screen instructions in branch transfer
> limits
>
>To test:
>1- go to cgi-bin/koha/admin/branch_transfer_limits.pl
>2- see wording "Check the boxes for the libraries you accept to checkin items from"
>3- apply patch
>4- see wording "Check the boxes for the libraries you allow your items to be transferred to"
>
>To verify new wording accuractely describes behavior:
>1- Set UseBranchTransferLimits set to Enforce using itemtype
>2- Confirm circ rules allow holds
>3- Confirm hold policy by item type allows holds
>4- Confirm all branches are valid pickup locations in branch setup
>5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch
>6- Find a patron from Branch A
>7- Find a book from Branch B
>8- On the intranet, successfully place hold on item for patron for pickup at branch A
>9- Cancel hold
>10- Log into opac as patron
>11- Successfully place hold on item for pickup at Branch A
>12- Cancel hold
>13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch
>14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch
>15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option
>16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option
>
>Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>index e3cc5bb6ae..9dd039171b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>@@ -27,7 +27,7 @@
> </select>
> </form>
> 
>-Check the boxes for the libraries you accept to checkin items from.
>+Check the boxes for the libraries you allow your items to be transferred to.
> <fieldset>[% IF ( limitType == 'ccode' ) %]For all collection codes: [% ELSE %]For all item types: [% END %]<a id="CheckAll" href="#"> Select all</a> | <a id="UncheckAll" href="#"> Clear all</a></fieldset>
> 
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24747: 99715 | 99716 | 99808